Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the alpha <resource> delete command #2321

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Jan 20, 2025

Description

Changes proposed in this pull request:

  • make the delete template command

How to run it

  1. add the following configmap to the cluster:
apiVersion: v1
data:
  rootCommand: |
    name: function
    description: Set of commands for managing Functions
    descriptionLong: Use this command manage Functions
  resource: |
    scope: namespace
    kind: Function
    version: v1alpha2
    group: serverless.kyma-project.io
  templateCommands: |
    delete:
      description: "delete function"
      descriptionLong: "use this command to remove function from a cluster"
kind: ConfigMap
metadata:
  labels:
    kyma-cli/extension: resource
    kyma-project.io/module: function
  name: serverless.function.cli
  namespace: kyma-system
  1. build the cli from this PR:
go build --output kyma-dev main.go
  1. use command
./kyma-dev alpha --help

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2025
@pPrecel pPrecel added kind/feature Categorizes issue or PR as related to a new feature. area/cli Related to all activities around CLI and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 20, 2025
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2025
@pPrecel pPrecel marked this pull request as ready for review January 22, 2025 08:16
@pPrecel pPrecel requested a review from a team as a code owner January 22, 2025 08:16
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2025
@halamix2
Copy link
Member

/cla

@kyma-bot
Copy link

Successfully reached out to cla-assistant.io to initialize recheck of PR #2321

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 22, 2025
@pPrecel pPrecel enabled auto-merge (squash) January 22, 2025 10:02
@kyma-bot
Copy link

New changes are detected. LGTM label has been removed.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 22, 2025
@pPrecel pPrecel merged commit e7fa138 into kyma-project:main Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants