Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize empty list #3625

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Customize empty list #3625

merged 7 commits into from
Jan 24, 2025

Conversation

akucharska
Copy link
Contributor

Description

Changes proposed in this pull request:

  • allow to have a configuration option for ResourceList widget to render empty lists compactly without the extra graphics

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025
@akucharska akucharska linked an issue Jan 23, 2025 that may be closed by this pull request
Allow to skip special rendering of empty ResourceList for inline mode #3577
Closed
@mrCherry97 mrCherry97 self-assigned this Jan 23, 2025
mrCherry97
mrCherry97 requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should have "normal" big empty table
image

mrCherry97
mrCherry97 previously approved these changes Jan 23, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2025
@akucharska @grego952
Apply suggestions from code review
167125b 
Co-authored-by: Grzegorz Karaluch <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 23, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2025
@mrCherry97 mrCherry97 merged commit f274d8c into kyma-project:main Jan 24, 2025
15 checks passed
@mrCherry97 mrCherry97 deleted the customize-empty-list branch January 24, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to skip special rendering of empty ResourceList for inline mode
4 participants
@akucharska @mrCherry97 @grego952 @kyma-bot