Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create Service Binding when secret exists #826

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Fix create Service Binding when secret exists #826

merged 3 commits into from
Aug 21, 2024

Conversation

szwedm
Copy link
Contributor

@szwedm szwedm commented Aug 20, 2024

Description

Changes proposed in this pull request:

block a Service Binding creation when a secret with the given name and namespace exists in the cluster.

Related issue(s)

See #442

@szwedm szwedm self-assigned this Aug 20, 2024
@szwedm szwedm requested review from a team as code owners August 20, 2024 13:11
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. labels Aug 20, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@szwedm szwedm changed the base branch from main to sm-integration August 20, 2024 13:11
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 20, 2024
@szwedm szwedm removed the request for review from a team August 20, 2024 13:12
@szwedm szwedm added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Aug 20, 2024
@szwedm szwedm mentioned this pull request Aug 20, 2024
Closed
9 tasks
@szwedm szwedm force-pushed the sm-integration-fix-create-sb-when-secret-exists branch from f805616 to a5b47a4 Compare August 21, 2024 08:18
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 21, 2024
@MarekMichali MarekMichali merged commit 95a81d7 into kyma-project:sm-integration Aug 21, 2024
13 of 14 checks passed
szwedm added a commit that referenced this pull request Aug 21, 2024
@szwedm
Fix create Service Binding when secret exists (#826)
5114c13 
* Block SB creation when secret exists

* Add unit test for POST SB when secret exists

* go mod tidy
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@szwedm @kyma-gopher-bot
Fix create Service Binding when secret exists (#826)
d9d46ce 
* Block SB creation when secret exists

* Add unit test for POST SB when secret exists

* go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

@ralikio ralikio Awaiting requested review from ralikio

Assignees

@szwedm szwedm

@MarekMichali MarekMichali

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szwedm @MarekMichali @kyma-bot