Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show secret connection status to SM #825

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Show secret connection status to SM #825

merged 3 commits into from
Aug 21, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Aug 20, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Display message if connection to SM is established or not with selected secret
  • Fix a bug to not always set the 1st returned secret from the api as the current one, set only on page load

Related issue(s)

See #442

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2024
@MarekMichali MarekMichali marked this pull request as ready for review August 21, 2024 06:14
@MarekMichali MarekMichali requested a review from a team as a code owner August 21, 2024 06:14
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2024
@MarekMichali MarekMichali mentioned this pull request Aug 21, 2024
Closed
9 tasks
szwedm
szwedm approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 21, 2024
@MarekMichali MarekMichali merged commit 69469b3 into kyma-project:sm-integration Aug 21, 2024
11 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
@MarekMichali @szwedm
Show secret connection status to SM (#825)
13023fb 
* Show secret connection status to SM

* Add check if secret was not deleted during loading

* Fix linter
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@MarekMichali @kyma-gopher-bot
Show secret connection status to SM (#825)
a3ffa82 
* Show secret connection status to SM

* Add check if secret was not deleted during loading

* Fix linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarekMichali @kyma-bot @szwedm