Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secret operations in Service Binding related requests #812

Conversation

szwedm
Copy link
Contributor

@szwedm szwedm commented Aug 14, 2024

Description

Changes proposed in this pull request:

  • fix nil referencing in secrets slice while getting secrets for SB,
  • fix populating cluster id label when the label exists in SB.

Related issue(s)

See #442

@szwedm szwedm requested a review from a team as a code owner August 14, 2024 10:16
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 14, 2024
@szwedm szwedm merged commit 05dc4a7 into kyma-project:sm-integration Aug 14, 2024
13 of 14 checks passed
szwedm added a commit that referenced this pull request Aug 21, 2024
* Fix fetching secrets in GET Service Bindings

* Fix secret creation in POST Service Binding

* Fix assertion in test
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
* Fix fetching secrets in GET Service Bindings

* Fix secret creation in POST Service Binding

* Fix assertion in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants