Skip to content

Commit

Permalink
Add unit test for POST SB when secret exists
Browse files Browse the repository at this point in the history
  • Loading branch information
szwedm committed Aug 20, 2024
1 parent 040a495 commit 72eb53e
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 1 deletion.
41 changes: 41 additions & 0 deletions internal/api/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import (
"bytes"
"context"
"encoding/json"
"fmt"
"io"
"log/slog"
"net/http"
"testing"
Expand Down Expand Up @@ -555,6 +557,45 @@ func TestAPI(t *testing.T) {
fakeSM.RespondWithData()
})

t.Run("POST Service Binding 409 error", func(t *testing.T) {
// given
secretName, secretNamespace := "sb-test-01-secret", "default"
sbCreateRequest := requests.CreateServiceBinding{
Name: "sb-test-01",
ServiceInstanceID: "a7e240d6-e348-4fc0-a54c-7b7bfe9b9da6",
Parameters: []byte(`{"param1": "value1", "param2": "value2"}`),
SecretName: secretName,
SecretNamespace: secretNamespace,
}
sbCreateRequestJSON, err := json.Marshal(sbCreateRequest)
require.NoError(t, err)

existingSecret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: secretName,
Namespace: secretNamespace,
},
StringData: map[string]string{"foo": "bar"},
}
require.NoError(t, secretMgr.Create(context.TODO(), existingSecret))

req, err := http.NewRequest(http.MethodPost, apiAddr+"/api/service-bindings", bytes.NewBuffer(sbCreateRequestJSON))
require.NoError(t, err)
resp, err := apiClient.Do(req)
require.NoError(t, err)

defer resp.Body.Close()
msgBytes, err := io.ReadAll(resp.Body)
require.NoError(t, err)

// then
require.Equal(t, http.StatusConflict, resp.StatusCode)
assert.Contains(t, fmt.Sprintf("secret \"%s\" in \"%s\" namespace already exists", secretName, secretNamespace), string(msgBytes))

// cleanup
err = secretMgr.Delete(context.TODO(), existingSecret)
})

t.Run("DELETE Service Binding by ID", func(t *testing.T) {
// given
sbID := "318a16c3-7c80-485f-b55c-918629012c9a"
Expand Down
3 changes: 2 additions & 1 deletion internal/cluster-object/fake.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"

corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

Expand Down Expand Up @@ -37,7 +38,7 @@ func (p *FakeSecretManager) GetByNameAndNamespace(ctx context.Context, name, nam
return secret, nil
}
}
return nil, fmt.Errorf("secret not found")
return nil, errors.NewNotFound(corev1.Resource("secret"), name)
}

func (p *FakeSecretManager) Clean() {
Expand Down

0 comments on commit 72eb53e

Please sign in to comment.