Replace fabric8-maven-plugin dependency with Eclipse JKube OpenShift Maven Plugin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fabric8 Maven Plugin (FMP) will be deprecated soon, Eclipse JKube should be used instead.
Eclipse JKube 1.3.0 was recently released, and as part of the core maintainer team, we need feedback from the community to see if current projects depending on FMP can be easily upgraded to use JKube. As part of the strategy to seek this feedback we are creating PRs on those repositories which we know are currently using FMP.
The JKube part works OK, however, it seems that the jar packaging (spring-boot:repackage) doesn't work well with
KieServices.Factory.get().getKieClasspathContainer().newKieSession(name).If the application is run directly there's no problem, however when packaged as a Jar and run locally, the session is not found. Probably that part needs an update too.