Ruff f821 fix in byte.py #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove yamllint
Catchup 20241128
This requires adding an import, python-magic. I don't know what byte.py is for, or whether you want this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff had an F821 error in byte.py complaining about magic, which wasn't imported.
As this file is manipulating byte files of different varieties, if you want to do that, this patch should enable that.
The fix is to import python-magic, and magic in byte.py.
Another approach would be to remove mention of the magic file check in byte.py at line 577, 684
📚 Documentation preview 📚: https://swarms--681.org.readthedocs.build/en/681/