Allow more flexible nested types #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively side-steps the entire Terraform type-system. The issue is that in Terraform, a list containing `DynamicValue`, still has to have all of the dynamic values reconcilable to the same type. This doesn't apply to `x-kubernetes-int-or-string`, though there it can be worked around by converting all to string. However, with more complicated types that are `x-kubernetes-preserve-unknown-fields`, this will not be possible. Therefore, make everything dynamic, and handle checking ourselves. The one downside is that IDE integrations etc can't use the schema types for type-hints. This may be worth revisiting when github.com/hashicorp/terraform#33916 is resolved.
We need to instantiate partial manifests in some places, notably after the first phase of import. However, when setting the state, the full value validation triggers, which rejects the partial update. Attribute validation only triggers when ingesting the config, which works out here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively side-steps the entire Terraform type-system. The issue is that in Terraform, a list containing
DynamicValue, still has to have all of the dynamic values reconcilable to the same type. This doesn't apply tox-kubernetes-int-or-string, though there it can be worked around by converting all to string. However, with more complicated types that arex-kubernetes-preserve-unknown-fields, this will not be possible.Therefore, make everything dynamic, and handle checking ourselves. The one downside is that IDE integrations etc can't use the schema types for type-hints.
This may be worth revisiting when github.com/hashicorp/terraform#33916 is resolved.