Add missing runtime/install-time dependencies to setup.py #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies should be part of the package metadata so that
pip install, RPM dependency generators, and many other things work as expected.This includes and builds on #76, which added
setuptoolsforimport pkg_resources; to that, I have addedclick,h5py,numpy,scipy,six, andtqdm.I chose not to add a hard dependency on
klustakwik2, which is needed only for theklusta.klustakwik.sparsify_features_masks()API function. Optional dependencies like this are a good fit for Extras, and adding one could be a good follow-up to this PR if development on this project picks back up at some point.