Skip to content

getProjectionStatus #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

getProjectionStatus #268

wants to merge 1 commit into from

Conversation

George-Payne
Copy link
Member

Implement getProjectionStatus.

ref: #238

@oskardudycz
Copy link
Contributor

@George-Payne, could you add a snippet for that method like, e.g. in the .NET client? https://github.com/EventStore/EventStore-Client-Dotnet/blob/master/samples/projection-management/Program.cs#L294

UnknownError,
} from "@eventstore/db-client";

describe("getProjectionStatistics", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: I think it'd be more consistent if we use the same semantics in test names as in the method name.

Suggested change
describe("getProjectionStatistics", () => {
describe("getProjectionStatus", () => {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste issue :D

options: baseOptions,
});

const { projectionStatus } = await this.getProjectionStatistics(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Shouldn't we mark getProjectionStatistics and GetProjectionStatisticsOptions as obsolete/deprecated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm 🤔 that's weird.

Copy link
Contributor

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments above.

@George-Payne
Copy link
Member Author

George-Payne commented Feb 1, 2022

Some confusion around the RFC, will close this.

see: https://github.com/EventStore/architecture-and-planning/pull/100

superseeded by: #269

@George-Payne George-Payne deleted the getProjectionStatus branch February 1, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants