-
Notifications
You must be signed in to change notification settings - Fork 24
getProjectionStatus #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getProjectionStatus #268
Conversation
@George-Payne, could you add a snippet for that method like, e.g. in the .NET client? https://github.com/EventStore/EventStore-Client-Dotnet/blob/master/samples/projection-management/Program.cs#L294 |
UnknownError, | ||
} from "@eventstore/db-client"; | ||
|
||
describe("getProjectionStatistics", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUGGESTION: I think it'd be more consistent if we use the same semantics in test names as in the method name.
describe("getProjectionStatistics", () => { | |
describe("getProjectionStatus", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy paste issue :D
options: baseOptions, | ||
}); | ||
|
||
const { projectionStatus } = await this.getProjectionStatistics( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUGGESTION: Shouldn't we mark getProjectionStatistics
and GetProjectionStatisticsOptions
as obsolete/deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're still a supported operation: https://github.com/EventStore/architecture-and-planning/blob/main/rfcs/021%20-%20gRPC%20Projections.md#supported-operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm 🤔 that's weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments above.
Some confusion around the RFC, will close this. see: https://github.com/EventStore/architecture-and-planning/pull/100 superseeded by: #269 |
Implement
getProjectionStatus
.ref: #238