Verify null material handling in Renderer.sharedMaterials access#2
Draft
Verify null material handling in Renderer.sharedMaterials access#2
Conversation
Co-authored-by: kurotu <[email protected]>
Co-authored-by: kurotu <[email protected]>
Copilot
AI
changed the title
[WIP] Fix reference error caused by null materials in Renderer.sharedMaterials
Verify null material handling in Renderer.sharedMaterials access
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity's
Renderer.sharedMaterialscan contain null entries when materials are missing. The issue reported reference errors in Quick Variant list display and material application, requesting fixes across the codebase.Analysis Results
All
sharedMaterialsaccess points already implement proper null filtering:QuickVariantWindow.cs
GetMaterials(): Filters nulls after concatenating all material sources (line 224:.Where(m => m != null))OnClickCreateMaterials(): Explicit null check when applying materials (lines 175-178)MaterialReplacerWindow.cs
GetRendererMaterials(): Filters nulls immediately (line 31:.Where(m => m != null))OnClickApply(): Explicit null check when applying materials (lines 158-160)MaterialReplacerRuleEditor.cs
GetMaterials(): Filters nulls before return (line 69:.Where(m => m != null))No code changes required. The base commit already contains comprehensive null handling for all identified scenarios.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.