Skip to content

fix(sharing): preserve invitation completion state#1359

Merged
kunickiaj merged 1 commit into
mainfrom
07-25-fix_sharing_preserve_invitation_completion_state
Jul 25, 2026
Merged

fix(sharing): preserve invitation completion state#1359
kunickiaj merged 1 commit into
mainfrom
07-25-fix_sharing_preserve_invitation_completion_state

Conversation

@kunickiaj

@kunickiaj kunickiaj commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Description

Keep successful Team and add-device invitation acceptance visible in the open dialog instead of resetting to the paste form.

The dialog now enters a stable, focused completion state with truthful restart guidance, removes all repeat review/accept controls, guards against duplicate submissions, and resets only after explicit close/reopen. Project-share completion behavior remains unchanged. The raw close glyph is replaced with the shared accessible close-button primitive, and the result uses a restrained responsive success surface consistent with existing theme tokens.

This fixes the dogfood failure where successful acceptance looked like a reset or failed operation.

Type of Change

  • 🚀 Feature (new functionality)
  • 🐛 Bug fix (fixes an issue)
  • 📚 Documentation (docs-only change)
  • 🔧 Maintenance (refactor, chore, CI, etc.)
  • 🧪 Testing (test-only changes)

Testing

  • Relevant checks pass locally (pnpm run tsc, pnpm run lint, pnpm run test)
  • Added/updated tests for changes
  • Manually verified changes work as expected

Additional validation:

  • pnpm exec vitest run packages/ui/src/tabs/recipient-policy-invitations.test.tsx
  • pnpm --filter @codemem/ui typecheck
  • pnpm --filter @codemem/ui build
  • Independent state-machine, accessibility, and test-coverage reviews

Checklist

  • Code follows project style (pnpm run lint passes for touched files)
  • Self-review completed
  • Documentation updated (if needed)
  • No new warnings introduced

kunickiaj commented Jul 25, 2026

Copy link
Copy Markdown
Owner Author

@kunickiaj
kunickiaj marked this pull request as ready for review July 25, 2026 10:01
@kunickiaj
kunickiaj changed the base branch from 07-25-feat_sharing_authorize_identity-owned_device_invites to main July 25, 2026 15:01
@kunickiaj
kunickiaj force-pushed the 07-25-fix_sharing_preserve_invitation_completion_state branch from ff92094 to b327990 Compare July 25, 2026 15:01
@graphite-app

graphite-app Bot commented Jul 25, 2026

Copy link
Copy Markdown

Merge activity

  • Jul 25, 3:02 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jul 25, 3:05 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jul 25, 3:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 25, 3:11 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 25, 3:15 PM UTC: @kunickiaj merged this pull request with Graphite.

@kunickiaj
kunickiaj changed the base branch from main to graphite-base/1359 July 25, 2026 15:05
@kunickiaj
kunickiaj force-pushed the 07-25-fix_sharing_preserve_invitation_completion_state branch from b327990 to 523ee06 Compare July 25, 2026 15:05
@kunickiaj
kunickiaj changed the base branch from graphite-base/1359 to 07-25-feat_sharing_authorize_identity-owned_device_invites-v2 July 25, 2026 15:05
@kunickiaj
kunickiaj force-pushed the graphite-base/1359 branch from ab64d8d to e983b74 Compare July 25, 2026 15:05
@graphite-app
graphite-app Bot changed the base branch from 07-25-feat_sharing_authorize_identity-owned_device_invites-v2 to main July 25, 2026 15:05
@kunickiaj
kunickiaj changed the base branch from main to graphite-base/1359 July 25, 2026 15:09
@kunickiaj
kunickiaj changed the base branch from graphite-base/1359 to 07-25-feat_sharing_authorize_identity-owned_device_invites-v2 July 25, 2026 15:10
@kunickiaj
kunickiaj changed the base branch from 07-25-feat_sharing_authorize_identity-owned_device_invites-v2 to graphite-base/1359 July 25, 2026 15:10
@kunickiaj
kunickiaj changed the base branch from graphite-base/1359 to main July 25, 2026 15:10
@kunickiaj
kunickiaj force-pushed the 07-25-fix_sharing_preserve_invitation_completion_state branch from 523ee06 to cf78ee7 Compare July 25, 2026 15:11
@kunickiaj
kunickiaj merged commit 2142458 into main Jul 25, 2026
13 checks passed
@kunickiaj
kunickiaj deleted the 07-25-fix_sharing_preserve_invitation_completion_state branch July 25, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant