Skip to content

feat(sharing): define recipient policy contracts#1338

Merged
kunickiaj merged 1 commit into
mainfrom
07-21-feat_sharing_define_recipient_policy_contracts
Jul 22, 2026
Merged

feat(sharing): define recipient policy contracts#1338
kunickiaj merged 1 commit into
mainfrom
07-21-feat_sharing_define_recipient_policy_contracts

Conversation

@kunickiaj

@kunickiaj kunickiaj commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Description

Define the contract boundary for the project-recipient sharing redesign tracked by codemem-hop0.1.

  • records the approved Project → Identity/Team product model and eight-PR implementation plan
  • decides that actors back Identities while policy Teams remain distinct from coordinator groups
  • defines per-Project authority cutover, attributed actionable review, legacy invitation, and navigation compatibility rules
  • adds dependency-free V1 TypeScript contracts separating intent, effective devices, and current scope enforcement
  • adds pure contract fixtures without changing persistence, routes, migrations, or authorization behavior

This builds on the merged exact-project sharing stack; it does not revert or weaken its scope enforcement, provisioning, invitation binding, or replication behavior.

Type of Change

  • 🚀 Feature (new functionality)
  • 🐛 Bug fix (fixes an issue)
  • 📚 Documentation (docs-only change)
  • 🔧 Maintenance (refactor, chore, CI, etc.)
  • 🧪 Testing (test-only changes)

Testing

  • Relevant checks pass locally (pnpm run tsc, pnpm run lint, pnpm run test)
  • Added/updated tests for changes
  • Manually verified changes work as expected

Validation:

  • pnpm run check — 150 files passed, 2,809 tests passed, 3 todo
  • pnpm exec vitest run packages/core/src/recipient-policy-contract.test.ts — 10 passed
  • git diff --check
  • independent CodeReviewer and ADR review; no P0/P1 findings after corrections

Checklist

  • Code follows project style (pnpm run lint passes for touched files)
  • Self-review completed
  • Documentation updated (if needed)
  • No new warnings introduced

kunickiaj commented Jul 22, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jul 22, 9:25 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 22, 9:26 PM UTC: @kunickiaj merged this pull request with Graphite.

@kunickiaj
kunickiaj merged commit d560a6a into main Jul 22, 2026
11 checks passed
@kunickiaj
kunickiaj deleted the 07-21-feat_sharing_define_recipient_policy_contracts branch July 22, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant