fix: make the generated skill defer to live CLI guidance - #48
Merged
Conversation
Installed skills go stale when the npm package is bumped. Keep only identity frontmatter plus pointers to live CLI help so regeneration cannot re-inflate baked command docs. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 24, 2026
yjuyjuy
added a commit
to yjuyjuy/tasks-axi
that referenced
this pull request
Aug 24, 2026
…e no-mistakes gate to the shared action (#6) * fix(cli): speed up standalone version queries (kunchenguid#34) * perf(cli): answer --version through the axi-sdk-js fast path Extract the package-version helper out of the heavy `src/cli.ts` graph into a leaf `src/version.ts` (node builtins only), and rewrite `bin/tasks-axi.ts` to answer a bare `-v`/`-V`/`--version` via `axi-sdk-js/fast-path`, dynamically importing the command graph only for everything else. Bumps axi-sdk-js to ^0.1.10 for the `./fast-path` subpath export. Version output is byte-identical and all other argv shapes still route through `runAxiCli` unchanged. Guarded by a deterministic ESM loader module trace with a negative control plus flag parity; no wall-clock assertion in CI. * no-mistakes(document): Confirm fast-path docs and lint cleanliness * no-mistakes: apply CI fixes * chore(main): release tasks-axi 0.2.5 (kunchenguid#35) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(cli): accept canonical Forgejo pull request URLs (kunchenguid#36) * fix: accept canonical Forgejo pull request URLs as typed PR links One classification seam (isPrUrl in src/pr-url.ts) now decides what counts as a PR URL for prose link derivation, done/add --pr validation, and public-followup pr_url deliverables: canonical GitHub https://github.com/<owner>/<repo>/pull/<n> or Forgejo https://<host>/<owner>/<repo>/pulls/<n> with a positive, no-leading-zero number. Near misses (issue routes, singular/plural route confusion, trailing slash, query/fragment, whitespace, userinfo, ports, encoded separators, malformed segments) are rejected as --pr / pr_url values and derive as doc links, never pr. Fixes kunchenguid#19 * fix: validate pr links against the untrimmed input Review follow-ups from pipeline run 01KZFA73D662DCSJ4HVWKW21QX: --pr values and pr-kind addLinks are validated before any trim, so whitespace-padded input is rejected instead of normalized. The literal NUL byte in test/pr-url.test.ts is now written as a unicode source escape so git treats the file as text; an embedded-space rejection case is added alongside it. * chore: remove committed no-mistakes evidence (now on orphan branch) (kunchenguid#39) * chore: gitignore no-mistakes evidence dir (contributor safety) (kunchenguid#41) * chore(agents): use @AGENTS.md import instead of CLAUDE.md symlink (kunchenguid#42) Co-authored-by: Kun Chen <kun-1@kunchenguid.com> * ci: require no-mistakes pipeline attestation in the gate (kunchenguid#45) * ci: require no-mistakes pipeline attestation in the gate * test: run the no-mistakes gate script on POSIX legs only * ci: bind the no-mistakes attestation to the current PR head (kunchenguid#46) * ci: migrate the no-mistakes gate to the shared composite action (kunchenguid#47) Replace the inline gate `run:` block in .github/workflows/no-mistakes-required.yml with a thin caller of kunchenguid/no-mistakes/.github/actions/require-no-mistakes, pinned to an immutable commit SHA. Enforcement logic and its tests now live upstream, so this repository no longer carries a hand-copied script that can drift from its siblings. Drop `synchronize` from the pull_request trigger: the verdict is a pure function of the PR body, and the pipeline pushes before it writes the Pipeline section, so a push-triggered run pinned a failure to a head whose body the same run was about to fix. This repo's ruleset is advisory with no required status check, so dropping the trigger cannot wedge a merge. Remove test/workflows/no-mistakes-gate.test.ts, which extracted and executed the now-absent inline block, and point AGENTS.md at the shared action. * fix: make the generated skill defer to live CLI guidance (kunchenguid#48) * fix(skill): shrink SKILL.md to a CLI-deferring stub Installed skills go stale when the npm package is bumped. Keep only identity frontmatter plus pointers to live CLI help so regeneration cannot re-inflate baked command docs. Co-authored-by: Cursor <cursoragent@cursor.com> * no-mistakes(review): Align skill documentation with minimal generator contract * no-mistakes(document): Consolidate generated skill documentation --------- Co-authored-by: Cursor <cursoragent@cursor.com> * no-mistakes: apply CI fixes --------- Co-authored-by: Kun Chen <3233006+kunchenguid@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Evelyn Scidmore <13389701+escidmore@users.noreply.github.com> Co-authored-by: Kun Chen <kun-1@kunchenguid.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Chris Yuan <cyuan@hyfin.app>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix tasks-axi's skill-fragmentation problem: cut skills/tasks-axi/SKILL.md drastically to a minimal stub that defers to the CLI as the single source of truth, via the GENERATOR so the contract holds on every regeneration. Same minimal-stub pattern the captain approved for lavish-axi, applied family-wide.
The skill duplicates instructions the tasks-axi CLI already prints (help / subcommand / dashboard). Users install the skill once and never update it when they bump the npm package, so the baked copy goes stale. The skill already opens well and defers, but it also bakes a Commands index, a long Tips flag-detail section, and exact-syntax Workflow steps that mirror the CLI.
CRITICAL: fix the GENERATOR (src/skill.ts, via scripts/build-skill.ts / pnpm run build:skill), not just the current output. CI runs pnpm run build:skill -- --check and fails on drift. A future regeneration must not re-inflate the skill.
Keep frontmatter (name/description/metadata). Body only: what tasks-axi is (one or two lines), when to reach for it, and pointers telling the agent to get actual instructions from the CLI: npx -y tasks-axi (dashboard), npx -y tasks-axi --help, and npx -y tasks-axi --help. Remove the Commands index, the Tips flag-detail section, and exact-syntax duplication in Workflow.
Document the contract in tasks-axi AGENTS.md: the shipped skill stays minimal and defers to the CLI for all actual guidance (CLI output is the single source of truth); never re-duplicate CLI-owned instructions into the skill; prefer a pointer over restated detail.
The CLI itself is UNCHANGED: do not remove or shrink --help, subcommand, or dashboard output.
Do not merge. No Greptile on tasks-axi. Captain merges and decides the release.
What Changed
Risk Assessment
🚨 High: The change is otherwise well-bounded, but the generated body directly contradicts an explicit authoritative acceptance constraint and should not merge without human resolution.
Testing
Verified the generator emits the minimal CLI-deferring skill without drift, the focused skill tests pass, and the unchanged dashboard, top-level help, and command help remain available end to end. Initial invalid flag-order and external-cwd evidence attempts were discarded and repeated through supported interfaces.
Evidence: Regenerated minimal tasks-axi skill
Source: Regenerated minimal tasks-axi skill
Evidence: Live CLI dashboard, top-level help, and subcommand help transcript
Source: Live CLI dashboard, top-level help, and subcommand help transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
README.md:268- The generator no longer embeds CLI help, but README.md still says the skill is generated from CLI description and help, while CONTRIBUTING.md:39 still directs regeneration after top-level help changes. Update both to describe the minimal CLI-deferring stub so contributor guidance does not preserve the retired anti-pattern.🔧 Fix: Align skill documentation with minimal generator contract
1 error still open:
src/skill.ts:58- Intent requires the body to contain only what tasks-axi is, when to use it, and the three specified CLI pointers. This additional follow-up rewriting instruction (tasks-axitonpx -y tasks-axi ...) is CLI invocation guidance outside that closed list and contradicts the documented minimal-body contract at lines 26-30. Confirm whether this exception is intentional or remove it from the generator and generated skill.✅ **Test** - passed
✅ No issues found.
pnpm exec vitest run test/skill.test.tspnpm run build:skillfollowed bypnpm run build:skill -- --checkpnpm exec tsx bin/tasks-axi.tspnpm exec tsx bin/tasks-axi.ts --helppnpm exec tsx bin/tasks-axi.ts show --helpCaptured the regenerated skill and live CLI dashboard/help outputs as reviewer-visible evidence.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.