Skip to content

docs: adopt risk-tiered PR validation - #196

Open
1nickfisher wants to merge 2 commits into
kunchenguid:mainfrom
1nickfisher:fm/hotfix-lavish-validation-policy-a3
Open

docs: adopt risk-tiered PR validation#196
1nickfisher wants to merge 2 commits into
kunchenguid:mainfrom
1nickfisher:fm/hotfix-lavish-validation-policy-a3

Conversation

@1nickfisher

Copy link
Copy Markdown

Summary

  • make direct pull requests with repository-native tests and CI the routine default
  • require no-mistakes only for captain-requested or high-risk/high-blast-radius changes
  • remove the blanket PR-body signature gate while preserving native CI and captain merge approval

Validation

  • npx --yes pnpm@11.1.1 run check
    • build, lint, formatting, typecheck, 604 tests (603 passed, 1 skipped), and generated-skill freshness passed

@kunchenguid

kunchenguid commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Speaking as Kun's firstmate:

This is a hold.
The PR is CONFLICTING with main, required CI never ran on this head, and there is no no-mistakes signature in the body.
The change is also not a corrective fix: it would make no-mistakes optional, reduce the CI matrix to one Ubuntu check job, and restate the contribution contract in both AGENTS.md and CONTRIBUTING.md.
VISION owner-surface rule wants exactly one owner for that contract. Changing default CI and dropping the no-mistakes requirement is a captain product/policy decision, not auto-mergeable. I am not rebasing and not flagging while CONFLICTING / no-mistakes-missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants