docs: add pg-axi to the community catalog - #126
Conversation
|
Speaking as Kun's firstmate: independent source review of the proposed catalog add. Pin inspected: https://github.com/Abdul-Rehman6/pg-axi at 194576c83d2bbfde6568263a5562f30d32043a31 (current main HEAD; catalog.yaml has no pin field, matching existing schema). I did not execute the package. Source actually read: README.md, package.json, src/index.ts, src/commands/query.ts. Observations from that source, not the PR body: this is a real PostgreSQL AXI (custom TOON renderer, not axi-sdk-js). No-args home lists tables with row/column counts. Commands: table, query, search, indexes, explain. Unknown flags fail loud; never reads stdin / never prompts for credentials. Empty query results print "0 rows matched". Optional --json is an escape hatch, never the default. Metadata matches the package (pg-axi, PostgreSQL, Abdul-Rehman6). Not official, empty, malware, or a squat of this author's identity. I am not admitting it yet for two independent reasons:
VISION.md per-rule verdict:
Not merging. Not a Firstmate flag (identity collision is a contributor fix, not a default-behavior call). |
kunchenguid
left a comment
There was a problem hiding this comment.
Speaking as Kun's firstmate: source is a real AXI, but catalog name pg-axi collides with the existing thatdudealso/pg-axi entry. Please pick a distinct catalog name and rebase. Not merging.
What Changed
pg-axientry (authorAbdul-Rehman6, domain PostgreSQL) to thecommunitylist incatalog.yaml.README.mdanddocs/index.htmlwith the matching row.Risk Assessment
✅ Low: Docs-only addition of one community catalog entry; the generated README and HTML regions are consistent with what scripts/generate-docs.mjs plus prettier would emit, and the linked repository resolves.
Testing
Ran the docs generator's own check and unit tests to prove the committed README and site rows are exactly what catalog.yaml generates, then rendered docs/index.html in headless Chrome and captured a screenshot of the Community table showing the new pg-axi row as an end user would see it, and confirmed the linked repo URL returns 200. Everything the change intended works, but the visual check revealed the catalog already contains a different pg-axi entry (thatdudealso, also PostgreSQL), so two identically-named rows now appear and the generator has no duplicate-name guard - that needs an author decision.
/var/folders/3g/gf0z3mxn10963w_9yz8k3jm40000gq/T/no-mistakes-evidence/01KZDGGZ46T0MP11S3GMYZD979/community-catalog-pg-axi.png)/var/folders/3g/gf0z3mxn10963w_9yz8k3jm40000gq/T/no-mistakes-evidence/01KZDGGZ46T0MP11S3GMYZD979/community-catalog.png)Evidence: Generated README rows - both pg-axi entries
Evidence: docs:check - generated regions match catalog.yaml
Pipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
⏭️ **Test** - skipped
catalog.yaml:154- The community catalog now lists two distinct entries both namedpg-axiin the PostgreSQL domain: the pre-existingthatdudealso/pg-axi(catalog.yaml:109) and the newly addedAbdul-Rehman6/pg-axi(catalog.yaml:154). The docs generator performs no duplicate-name validation, sopnpm run docs:checkpasses and the rendered site + README show two identically-labelledpg-axirows, which is ambiguous for readers choosing a tool. Needs a product decision: rename the new entry, disambiguate the label, or accept the collision.pnpm install --ignore-scripts(workspace deps for the docs generator)pnpm run docs:check- regenerates catalog regions from catalog.yaml and asserts committed README.md / docs/index.html match; passed with no driftpnpm run docs:test(node --test scripts/generate-docs.test.mjs) - generator escaping/link/table semantics; 4/4 passedManual render: headless Chrome screenshot ofdocs/index.htmlcommunity catalog table, confirming the new pg-axi row renders with correct author, domain, description and linkcurl -s -o /dev/null -w "%{http_code}" https://github.com/Abdul-Rehman6/pg-axi- catalog URL resolves (200)grep -n "pg-axi" catalog.yaml README.md docs/index.html- surfaced the duplicate-name collision with the existing thatdudealso/pg-axi entry✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.