Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(images/kuma-init): use iptables-wrapper to use correct iptables version (backport of #9701) (#9728)" #9755

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Revert "feat(images/kuma-init): use iptables-wrapper to use correct iptables version (backport of #9701) (#9728)" #9755

merged 1 commit into from
Mar 29, 2024

Conversation

bartsmykla
Copy link
Contributor

This reverts commit 5711de2.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@bartsmykla
Revert "feat(images/kuma-init): use iptables-wrapper to use correct i…
dda3318 
…ptables version (backport of kumahq#9701) (kumahq#9728)"

This reverts commit 5711de2.

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Mar 29, 2024
@bartsmykla bartsmykla requested a review from slonka March 29, 2024 08:44
@bartsmykla bartsmykla requested a review from a team as a code owner March 29, 2024 08:44
@bartsmykla bartsmykla requested review from michaelbeaumont and lukidzi and removed request for a team March 29, 2024 08:44
@bartsmykla bartsmykla enabled auto-merge (squash) March 29, 2024 08:47
@bartsmykla bartsmykla merged commit 5de0b6e into kumahq:release-2.5 Mar 29, 2024
11 checks passed
@bartsmykla bartsmykla deleted the chore/revert-iptables-wrapper-changes-release-2.5 branch March 29, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartsmykla @slonka