Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add possibily to rely on secret for caBundle #9342

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Feb 21, 2024

Also add support for using system CA bundle

fix #9324

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: skip

Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one error message seems od too me

Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't easily diff this again what I reviewed earlier, check that comments were actually resolved - trusting nothing else major has changed

@lahabana
Copy link
Contributor Author

@jakubdyszkiewicz would love a review on this because I think you are the one that pointed out some specific edge cases.

@slonka
Copy link
Contributor

slonka commented Mar 28, 2024

pinging @jakubdyszkiewicz again - when you have time, please take a look at this

@lahabana lahabana closed this Mar 29, 2024
@lahabana lahabana deleted the fix9324 branch March 29, 2024 12:43
@lahabana lahabana restored the fix9324 branch April 8, 2024 18:58
@lahabana lahabana reopened this Apr 8, 2024
@lahabana lahabana added this to the 2.7.x milestone Apr 8, 2024
@lahabana
Copy link
Contributor Author

lahabana commented Apr 8, 2024

@jakubdyszkiewicz please :)

@lahabana lahabana merged commit 7ad16bc into kumahq:master Apr 10, 2024
15 checks passed
jakubdyszkiewicz added a commit to jakubdyszkiewicz/kuma that referenced this pull request Apr 10, 2024
jakubdyszkiewicz added a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

having ca.crt inlined in a k8s secret doesn't work on helm instal.
3 participants