-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): add possibily to rely on secret for caBundle #9342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one error message seems od too me
fix kumahq#9324 Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't easily diff this again what I reviewed earlier, check that comments were actually resolved - trusting nothing else major has changed
@jakubdyszkiewicz would love a review on this because I think you are the one that pointed out some specific edge cases. |
pinging @jakubdyszkiewicz again - when you have time, please take a look at this |
@jakubdyszkiewicz please :) |
…hq#9342)" This reverts commit 7ad16bc. Signed-off-by: Jakub Dyszkiewicz <[email protected]>
#9897) This reverts commit 7ad16bc. Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Also add support for using system CA bundle
fix #9324
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --