Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): removed comma from last element #9340

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Feb 21, 2024

Checklist prior to review

full-matrix doesn't fail because it doesn't use jq

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lukidzi lukidzi requested a review from a team as a code owner February 21, 2024 16:43
@lukidzi lukidzi requested review from michaelbeaumont, slonka and lobkovilya and removed request for a team February 21, 2024 16:43
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh JSON!

@lukidzi lukidzi enabled auto-merge (squash) February 21, 2024 16:45
@michaelbeaumont michaelbeaumont added ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) and removed ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) labels Feb 21, 2024
@lukidzi lukidzi merged commit bfad622 into kumahq:master Feb 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants