Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): remove legacy KDS job #9338

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Feb 21, 2024

The new implementation will be on by default so remove the logic where KumaLegacyKDS == true.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Remove KDS v1 #9075
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Feb 21, 2024
@michaelbeaumont michaelbeaumont changed the title test(e2e_env): remove legacy KDS job test(e2e): remove legacy KDS job Feb 21, 2024
@michaelbeaumont michaelbeaumont marked this pull request as ready for review February 21, 2024 13:58
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner February 21, 2024 13:58
@michaelbeaumont michaelbeaumont requested review from slonka and removed request for a team February 21, 2024 13:58
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) February 21, 2024 14:03
@michaelbeaumont michaelbeaumont merged commit fe37d20 into kumahq:master Feb 21, 2024
34 checks passed
@michaelbeaumont michaelbeaumont deleted the test/e2e-legacy-kds branch February 21, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants