-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(k8s): sidecar containers #9321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3352850
to
ccc1ed2
Compare
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
6f5ffc4
to
21c005b
Compare
Signed-off-by: Mike Beaumont <[email protected]>
e1cec89
to
e7d7b49
Compare
michaelbeaumont
commented
Feb 21, 2024
Signed-off-by: Mike Beaumont <[email protected]>
22fc07b
to
e04a2b9
Compare
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
e04a2b9
to
51d30cb
Compare
lahabana
reviewed
Feb 21, 2024
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
CI seems to not be running. I'll do "update branch" to see if that triggers a that. |
That helped. |
jakubdyszkiewicz
approved these changes
Feb 22, 2024
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
.experimental
config flag. The feature isn't really experimental but it shouldn't be the default yet since the feaure is still beta.It adds a new job to the matrix that runs the Kubernetes tests with the features enabled.
Question: Do we think it's ok that it runs only on master or should it be run on PRs?
Note: all the added lines are the golden files for injector tests with sidecars enabled.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --