Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(unit): don't generate test reports for quicker tests #8825

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

lahabana
Copy link
Contributor

This uses go test instead of ginkgo cli This seems to run tests twice as quick.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

This uses `go test` instead of `ginkgo cli` This seems
to run tests twice as quick.

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested a review from a team as a code owner January 11, 2024 18:05
@lahabana lahabana requested review from jijiechen, michaelbeaumont and Automaat and removed request for a team January 11, 2024 18:05
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of odd that it takes so much longer, assuming it's running the same tests but 🤷

@lahabana
Copy link
Contributor Author

lahabana commented Jan 12, 2024

It's because of the way ginkgo runs stuff in parallel: https://onsi.github.io/ginkgo/#mental-model-how-ginkgo-runs-parallel-specs

It makes a lot of sense for e2e tests (which are long). It makes less sense for many small unit test suites.

@lahabana lahabana merged commit 653ffa4 into kumahq:master Jan 12, 2024
12 checks passed
@lahabana lahabana deleted the experimentQuickerUnitTests branch March 29, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants