Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): avoid starting 2 k8s clusters in test/e2e-kubernetes #8823

Merged
merged 1 commit into from
Jan 11, 2024
Merged

test(e2e): avoid starting 2 k8s clusters in test/e2e-kubernetes #8823

merged 1 commit into from
Jan 11, 2024

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 11, 2024 •
edited
Loading

left over from #8736

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana requested a review from a team as a code owner January 11, 2024 16:44
@lahabana lahabana requested review from jijiechen, michaelbeaumont and lukidzi and removed request for a team January 11, 2024 16:44
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@lahabana lahabana enabled auto-merge (squash) January 11, 2024 16:56
@lahabana lahabana merged commit f52f45c into kumahq:master Jan 11, 2024
17 checks passed
lukidzi pushed a commit to lukidzi/kuma that referenced this pull request Jan 12, 2024
@lahabana @lukidzi
test(e2e): avoid starting 2 k8s clusters in test/e2e-kubernetes (kuma…
de36a47 
…hq#8823)

left over from kumahq#8736

Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lahabana lahabana deleted the moveTest branch March 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @jakubdyszkiewicz