Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): run all test/e2e tests #8822

Merged
merged 5 commits into from
Jan 12, 2024
Merged

test(e2e): run all test/e2e tests #8822

merged 5 commits into from
Jan 12, 2024

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 11, 2024 •
edited
Loading

When moving from circleci we missed adding parallelisation to test/e2e so a portion of the jobs were not running.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana requested a review from a team as a code owner January 11, 2024 16:03
@lahabana lahabana requested review from jijiechen, michaelbeaumont and lobkovilya and removed request for a team January 11, 2024 16:03
@lahabana lahabana force-pushed the e2eImprovements branch 4 times, most recently from 189a3fd to 4f807a3 Compare January 12, 2024 10:10
@lahabana lahabana changed the title test(e2e): run all test/e2e tests and also on PRs test(e2e): run all test/e2e tests Jan 12, 2024
@lahabana lahabana mentioned this pull request Jan 12, 2024
Open
@lahabana
Copy link
Contributor Author

Covered the new ignored tests in: #8838

@lahabana lahabana enabled auto-merge (squash) January 12, 2024 13:38
@lahabana lahabana merged commit 53fe33c into kumahq:master Jan 12, 2024
11 checks passed
@lahabana lahabana deleted the e2eImprovements branch March 29, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @lukidzi