Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): check DPP name without zone prefix #8799

Merged
merged 1 commit into from
Jan 10, 2024
Merged

test(e2e): check DPP name without zone prefix #8799

merged 1 commit into from
Jan 10, 2024

Conversation

lobkovilya
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lobkovilya lobkovilya added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jan 10, 2024
@lobkovilya lobkovilya requested a review from a team as a code owner January 10, 2024 12:29
@lobkovilya lobkovilya requested review from jijiechen, michaelbeaumont and lukidzi and removed request for a team January 10, 2024 12:29
@lobkovilya lobkovilya merged commit a0a25e1 into kumahq:master Jan 10, 2024
35 checks passed
@lobkovilya lobkovilya deleted the fix/e2e-dpp-check branch January 10, 2024 14:24
lahabana added a commit that referenced this pull request Jan 11, 2024
@lahabana
test(e2e): fix ipv6 and helm failure
40d9ecc 
- Helm fix was only partial in #8799
- #8676 didn't do what it was expected to

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana mentioned this pull request Jan 11, 2024
Merged
5 tasks
lahabana added a commit that referenced this pull request Jan 11, 2024
@lahabana
test(e2e): fix ipv6 and helm failure (#8808)
c662a5b 
- Helm fix was only partial in #8799
- #8676 didn't do what it was expected to

Signed-off-by: Charly Molter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobkovilya @jakubdyszkiewicz