Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshRateLimit): support ExternalServices with ZoneEgress #8743

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jan 3, 2024

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lukidzi lukidzi changed the title feat(meshratelimit): support externalservices with zoneEgress feat(meshratelimit): support externalservices with egress Jan 4, 2024
@lukidzi lukidzi marked this pull request as ready for review January 4, 2024 14:35
@lukidzi lukidzi requested a review from a team as a code owner January 4, 2024 14:35
@lukidzi lukidzi requested review from Automaat and bartsmykla and removed request for a team January 4, 2024 14:35
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested a review from bartsmykla January 9, 2024 09:33
@lukidzi lukidzi merged commit 256f174 into kumahq:master Jan 9, 2024
12 checks passed
@lahabana lahabana changed the title feat(meshratelimit): support externalservices with egress feat(MeshRateLimit): support externalservices with egress Jan 29, 2024
@bartsmykla bartsmykla changed the title feat(MeshRateLimit): support externalservices with egress feat(MeshRateLimit): support ExternalServices with ZoneEgress Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants