-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(madr): logging standard #4445
Conversation
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4445 +/- ##
==========================================
- Coverage 55.51% 55.47% -0.04%
==========================================
Files 941 941
Lines 57669 57669
==========================================
- Hits 32017 31994 -23
- Misses 23110 23118 +8
- Partials 2542 2557 +15
Continue to review full report at Codecov.
|
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
removed 8. point altogether. After looking more at logs I'm not sure there is a stable pattern we can follow. Sometimes it make sense to log before action, sometimes after, sometimes both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the general direction of this MADR but I would like to understand some of the things mentioned here or change them if there is consensus to do so.
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Summary
I'd like to standardize a little bit a way how we handle logging in Kuma.
Please post suggestions!
Issues resolved
xref #879