Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(madr): logging standard #4445

Merged
merged 4 commits into from
Jun 28, 2022
Merged

docs(madr): logging standard #4445

merged 4 commits into from
Jun 28, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Jun 8, 2022

Summary

I'd like to standardize a little bit a way how we handle logging in Kuma.

Please post suggestions!

Issues resolved

xref #879

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner June 8, 2022 11:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #4445 (2b4573e) into master (739ed02) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4445      +/-   ##
==========================================
- Coverage   55.51%   55.47%   -0.04%     
==========================================
  Files         941      941              
  Lines       57669    57669              
==========================================
- Hits        32017    31994      -23     
- Misses      23110    23118       +8     
- Partials     2542     2557      +15     
Impacted Files Coverage Δ
pkg/defaults/mesh.go 64.28% <0.00%> (-14.29%) ⬇️
pkg/clusterid/creator.go 73.33% <0.00%> (-13.34%) ⬇️
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-11.12%) ⬇️
pkg/metrics/store/counter.go 74.54% <0.00%> (-10.91%) ⬇️
pkg/core/runtime/component/component.go 83.87% <0.00%> (-9.68%) ⬇️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (-7.70%) ⬇️
pkg/core/tokens/signing_key_manager.go 85.00% <0.00%> (-5.00%) ⬇️
...s/authn/api-server/tokens/admin_token_bootstrap.go 82.00% <0.00%> (-4.00%) ⬇️
pkg/defaults/components.go 82.14% <0.00%> (-3.58%) ⬇️
pkg/core/secrets/manager/global_manager.go 39.39% <0.00%> (-3.04%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739ed02...2b4573e. Read the comment docs.

docs/madr/decisions/003-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/003-logging.md Show resolved Hide resolved
docs/madr/decisions/003-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/003-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/003-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/003-logging.md Outdated Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz
Copy link
Contributor Author

removed 8. point altogether. After looking more at logs I'm not sure there is a stable pattern we can follow. Sometimes it make sense to log before action, sometimes after, sometimes both.

Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the general direction of this MADR but I would like to understand some of the things mentioned here or change them if there is consensus to do so.

docs/madr/decisions/003-logging.md Show resolved Hide resolved
docs/madr/decisions/003-logging.md Show resolved Hide resolved
docs/madr/decisions/003-logging.md Show resolved Hide resolved
@jakubdyszkiewicz jakubdyszkiewicz merged commit 5e12d42 into master Jun 28, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the docs/logging-standard branch June 28, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants