Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MADR): meshExternalService API madr #10229

Merged
merged 34 commits into from
May 22, 2024
Merged

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented May 13, 2024

Checklist prior to review

Additional PR for another resource #10253

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

lukidzi added 2 commits May 13, 2024 12:24
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi changed the title docs(madr): meshExternalService API madr docs(MADR): meshExternalService API madr May 13, 2024
@lukidzi lukidzi added ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) ci/skip-e2e-test PR: Don't run e2e tests labels May 13, 2024
lukidzi added 2 commits May 13, 2024 14:08
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi marked this pull request as ready for review May 13, 2024 19:14
@lukidzi lukidzi requested a review from a team as a code owner May 13, 2024 19:14
@lukidzi lukidzi requested review from jakubdyszkiewicz, Automaat and bartsmykla and removed request for a team May 13, 2024 19:14
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
docs/madr/decisions/049-meshexternalservice-api.md Outdated Show resolved Hide resolved
lukidzi and others added 4 commits May 14, 2024 07:25
Co-authored-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>
Signed-off-by: Krzysztof Słonka <[email protected]>
Co-authored-by: Charly Molter <[email protected]>
Signed-off-by: Krzysztof Słonka <[email protected]>
@slonka slonka mentioned this pull request May 21, 2024
5 tasks
slonka and others added 2 commits May 21, 2024 13:42
Signed-off-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@slonka slonka merged commit 0e9f776 into kumahq:master May 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants