Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): use EndpointSlices to determine identity for Service without selectors #10134

Merged
merged 9 commits into from
May 23, 2024
Merged

fix(k8s): use EndpointSlices to determine identity for Service without selectors #10134

merged 9 commits into from
May 23, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Apr 29, 2024 •
edited
Loading

This adds support for Services that don't have selectors.

  • respect labels/annotations
  • add unit test for managed EndpointSlice

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont changed the title fix(k8s): use EndpointSlices to determine Service endpoints fix(k8s): use EndpointSlices to determine Service identity without selectors May 3, 2024
@michaelbeaumont michaelbeaumont force-pushed the fix/use-endpoints branch 2 times, most recently from 18974d3 to 2850c03 Compare May 3, 2024 12:03
@michaelbeaumont michaelbeaumont changed the title fix(k8s): use EndpointSlices to determine Service identity without selectors fix(k8s): use EndpointSlices to determine identity for Service without selectors May 3, 2024
@lahabana
Copy link
Contributor

lahabana commented May 6, 2024

Why this change?

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented May 6, 2024 •
edited
Loading

@lahabana it's a missing feature. The impetus was that there are new Gateway API tests that test forwarding to Services with manually managed EndpointSlices. Which will prevent us from moving to v1.1

@michaelbeaumont @bartsmykla
Update pkg/plugins/runtime/k8s/util/util_test.go
656780c 
Co-authored-by: Bart Smykla <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
@bartsmykla
Copy link
Contributor

@lahabana it's a missing feature. The impetus was that there are new Gateway API tests that test forwarding to Services with manually managed EndpointSlices. Which will prevent us from moving to v1.1

Mentioned tests: kubernetes-sigs/gateway-api@d4132be

@michaelbeaumont michaelbeaumont marked this pull request as ready for review May 9, 2024 13:52
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner May 9, 2024 13:52
@michaelbeaumont michaelbeaumont requested review from slonka, Automaat, lobkovilya, lahabana and jakubdyszkiewicz and removed request for a team May 9, 2024 13:52
slonka
slonka approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging seems a bit off, otherwise looks fine

pkg/plugins/runtime/k8s/controllers/pod_controller.go Outdated Show resolved Hide resolved
pkg/plugins/runtime/k8s/controllers/pod_controller.go Outdated Show resolved Hide resolved
@michaelbeaumont
chore: fixed up logging
62b18a0 
Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont requested a review from slonka May 14, 2024 10:59
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label May 14, 2024
@michaelbeaumont michaelbeaumont merged commit 49ca160 into kumahq:master May 23, 2024
35 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/use-endpoints branch May 23, 2024 08:45
@michaelbeaumont michaelbeaumont mentioned this pull request Jun 17, 2024
Open
@BrewTestBot BrewTestBot mentioned this pull request Jun 24, 2024
Merged
@michaelbeaumont michaelbeaumont mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

@lahabana lahabana Awaiting requested review from lahabana

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelbeaumont @lahabana @bartsmykla @slonka @jakubdyszkiewicz