Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): remove inbound test cases in delegated gateway (backport of #10002) #10005

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 107 additions & 0 deletions test/e2e_env/kubernetes/gateway/delegated/meshcircuitbreaker.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
package delegated

Check failure on line 1 in test/e2e_env/kubernetes/gateway/delegated/meshcircuitbreaker.go

View workflow job for this annotation

GitHub Actions / lint

: # github.com/kumahq/kuma/test/e2e_env/kubernetes/gateway/delegated

import (
"fmt"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

"github.com/kumahq/kuma/pkg/plugins/policies/meshcircuitbreaker/api/v1alpha1"
meshretry_api "github.com/kumahq/kuma/pkg/plugins/policies/meshretry/api/v1alpha1"
"github.com/kumahq/kuma/test/framework"
"github.com/kumahq/kuma/test/framework/client"
"github.com/kumahq/kuma/test/framework/envs/kubernetes"
)

func CircuitBreaker(config *Config) func() {

Check failure on line 16 in test/e2e_env/kubernetes/gateway/delegated/meshcircuitbreaker.go

View workflow job for this annotation

GitHub Actions / lint

undefined: Config
GinkgoHelper()

return func() {
BeforeAll(func() {
Expect(framework.DeleteMeshPolicyOrError(

Check failure on line 21 in test/e2e_env/kubernetes/gateway/delegated/meshcircuitbreaker.go

View workflow job for this annotation

GitHub Actions / lint

undefined: framework.DeleteMeshPolicyOrError
kubernetes.Cluster,
v1alpha1.MeshCircuitBreakerResourceTypeDescriptor,
fmt.Sprintf("mesh-circuit-breaker-all-%s", config.Mesh),
)).To(Succeed())
Expect(framework.DeleteMeshPolicyOrError(

Check failure on line 26 in test/e2e_env/kubernetes/gateway/delegated/meshcircuitbreaker.go

View workflow job for this annotation

GitHub Actions / lint

undefined: framework.DeleteMeshPolicyOrError
kubernetes.Cluster,
meshretry_api.MeshRetryResourceTypeDescriptor,
fmt.Sprintf("mesh-retry-all-%s", config.Mesh),
)).To(Succeed())
})

framework.E2EAfterEach(func() {
Expect(framework.DeleteMeshResources(
kubernetes.Cluster,
config.Mesh,
v1alpha1.MeshCircuitBreakerResourceTypeDescriptor,
)).To(Succeed())
})

DescribeTable("should configure circuit breaker limits and outlier"+
" detectors for connections", func(yaml string) {
// given no MeshCircuitBreaker
mcbs, err := kubernetes.Cluster.GetKumactlOptions().
KumactlList("meshcircuitbreakers", config.Mesh)
Expect(err).ToNot(HaveOccurred())
Expect(mcbs).To(BeEmpty())

Eventually(func() ([]client.FailureResponse, error) {
return client.CollectResponsesAndFailures(
kubernetes.Cluster,
"demo-client",
fmt.Sprintf("http://%s/test-server", config.KicIP),
client.FromKubernetesPod(config.NamespaceOutsideMesh, "demo-client"),
client.WithNumberOfRequests(10),
)
}, "30s", "1s").Should(And(
HaveLen(10),
HaveEach(HaveField("ResponseCode", 200)),
))

// when
Expect(kubernetes.Cluster.Install(framework.YamlK8s(yaml))).To(Succeed())

// then
Eventually(func(g Gomega) ([]client.FailureResponse, error) {
return client.CollectResponsesAndFailures(
kubernetes.Cluster,
"demo-client",
fmt.Sprintf("http://%s/test-server", config.KicIP),
client.FromKubernetesPod(config.NamespaceOutsideMesh, "demo-client"),
client.WithNumberOfRequests(10),
// increase processing time of a request to increase
// a probability of triggering maxPendingRequest limit
client.WithHeader("x-set-response-delay-ms", "1000"),
client.WithoutRetries(),
)
}, "30s", "1s").Should(And(
HaveLen(10),
ContainElement(HaveField("ResponseCode", 503)),
))
},
Entry("outbound circuit breaker", fmt.Sprintf(`
apiVersion: kuma.io/v1alpha1
kind: MeshCircuitBreaker
metadata:
name: mcb-outbound-delegated
namespace: %s
labels:
kuma.io/mesh: %s
spec:
targetRef:
kind: Mesh
to:
- targetRef:
kind: Mesh
default:
connectionLimits:
maxConnectionPools: 1
maxConnections: 1
maxPendingRequests: 1
maxRequests: 1
maxRetries: 1
`, config.CpNamespace, config.Mesh)),
)
}
}
103 changes: 103 additions & 0 deletions test/e2e_env/kubernetes/gateway/delegated/meshtimeout.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
package delegated

import (
"fmt"
"time"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

meshretry_api "github.com/kumahq/kuma/pkg/plugins/policies/meshretry/api/v1alpha1"
"github.com/kumahq/kuma/pkg/plugins/policies/meshtimeout/api/v1alpha1"
"github.com/kumahq/kuma/test/framework"
"github.com/kumahq/kuma/test/framework/client"
"github.com/kumahq/kuma/test/framework/envs/kubernetes"
)

func MeshTimeout(config *Config) func() {

Check failure on line 17 in test/e2e_env/kubernetes/gateway/delegated/meshtimeout.go

View workflow job for this annotation

GitHub Actions / lint

undefined: Config (typecheck)
GinkgoHelper()

return func() {
BeforeAll(func() {
Expect(framework.DeleteMeshResources(
kubernetes.Cluster,
config.Mesh,
v1alpha1.MeshTimeoutResourceTypeDescriptor,
)).To(Succeed())

Expect(framework.DeleteMeshResources(
kubernetes.Cluster,
config.Mesh,
meshretry_api.MeshRetryResourceTypeDescriptor,
)).To(Succeed())
})

framework.E2EAfterEach(func() {
Expect(framework.DeleteMeshResources(
kubernetes.Cluster,
config.Mesh,
v1alpha1.MeshTimeoutResourceTypeDescriptor,
)).To(Succeed())
})

DescribeTable("should add timeouts", FlakeAttempts(3), func(timeoutConfig string) {
// given no MeshTimeout
mts, err := kubernetes.Cluster.GetKumactlOptions().KumactlList("meshtimeouts", config.Mesh)
Expect(err).ToNot(HaveOccurred())
Expect(mts).To(BeEmpty())

Eventually(func(g Gomega) {
start := time.Now()
_, err := client.CollectEchoResponse(
kubernetes.Cluster,
"demo-client",
fmt.Sprintf("http://%s/test-server", config.KicIP),
client.FromKubernetesPod(config.NamespaceOutsideMesh, "demo-client"),
client.WithHeader("x-set-response-delay-ms", "5000"),
client.WithMaxTime(10),
)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(time.Since(start)).To(BeNumerically(">", 5*time.Second))
}, "30s", "1s").Should(Succeed())

// when
Expect(framework.YamlK8s(timeoutConfig)(kubernetes.Cluster)).To(Succeed())

// then
Eventually(func(g Gomega) {
response, err := client.CollectFailure(
kubernetes.Cluster,
"demo-client",
fmt.Sprintf("http://%s/test-server", config.KicIP),
client.FromKubernetesPod(config.NamespaceOutsideMesh, "demo-client"),
client.WithHeader("x-set-response-delay-ms", "5000"),
client.WithMaxTime(10), // we don't want 'curl' to return early
)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(response.ResponseCode).To(Equal(504))
}, "1m", "1s", MustPassRepeatedly(5)).Should(Succeed())

Expect(framework.DeleteYamlK8s(timeoutConfig)(kubernetes.Cluster)).To(Succeed())
},
Entry("outbound timeout", fmt.Sprintf(`
apiVersion: kuma.io/v1alpha1
kind: MeshTimeout
metadata:
name: mt1-delegated
namespace: %s
labels:
kuma.io/mesh: %s
spec:
targetRef:
kind: Mesh
to:
- targetRef:
kind: Mesh
default:
idleTimeout: 20s
http:
requestTimeout: 2s
maxStreamDuration: 20s`, config.CpNamespace, config.Mesh)),
)
}
}
Loading