-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure levels of specific loggers #4446
Comments
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
I'm not sure I understand the "default" part of this sentence. Zap has AtomicLevel where you can set the log level, what we'd need to do is store this for every logger that we create and then expose an endpoint to set it individually. A PoC that set's it for all loggers is here: https://github.com/kumahq/kuma/compare/master...slonka:kuma:dynamic-log-level?expand=1#diff-8ee5e904442d62cebde1e84550f08579152de442c32f0f90fb4bcd793ecbe8f5R11 Let me know if this is what you had in mind. |
I something like slf4j. Yes, exactly, we would need to somehow store it for every logger we create. In your PoC I see dynamic logging level change for all loggers. That's ok, but more important part of this issue is level for specific loggers. I consider configuring it via HTTP API rather optional. More important is to configure this via cli, because it can survive restart. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
Duplicate of: #10230 |
Description
We need to have a system to adjust a log level for the specific logger.
It's important for systems that are shipped to users. Without that, adjusting the logging required a new release.
We try our best to pick a proper level, but we may pick the wrong level and have
go-logr and zap do not have a system like that by default.
Configuration can be via cli or by API calls in the runtime (nice to have)
Charly note: if we do this by API we need to call 5 instances (or X) to change it for every instance
The text was updated successfully, but these errors were encountered: