Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure levels of specific loggers #4446

Closed
jakubdyszkiewicz opened this issue Jun 8, 2022 · 10 comments
Closed

Configure levels of specific loggers #4446

jakubdyszkiewicz opened this issue Jun 8, 2022 · 10 comments
Labels
kind/feature New feature triage/duplicated already exists

Comments

@jakubdyszkiewicz
Copy link
Contributor

jakubdyszkiewicz commented Jun 8, 2022

Description

We need to have a system to adjust a log level for the specific logger.
It's important for systems that are shipped to users. Without that, adjusting the logging required a new release.
We try our best to pick a proper level, but we may pick the wrong level and have

  • missing observability by default
  • spamming the logging infrastructure

go-logr and zap do not have a system like that by default.

Configuration can be via cli or by API calls in the runtime (nice to have)

Charly note: if we do this by API we need to call 5 instances (or X) to change it for every instance

@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Jun 8, 2022
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jun 13, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 14, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jul 18, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 17, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Oct 31, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label May 2, 2023
@slonka
Copy link
Contributor

slonka commented Jun 23, 2023

go-logr and zap do not have a system like that by default.

I'm not sure I understand the "default" part of this sentence. Zap has AtomicLevel where you can set the log level, what we'd need to do is store this for every logger that we create and then expose an endpoint to set it individually. A PoC that set's it for all loggers is here: https://github.com/kumahq/kuma/compare/master...slonka:kuma:dynamic-log-level?expand=1#diff-8ee5e904442d62cebde1e84550f08579152de442c32f0f90fb4bcd793ecbe8f5R11

Let me know if this is what you had in mind.

@jakubdyszkiewicz
Copy link
Contributor Author

I'm not sure I understand the "default" part of this sentence

I something like slf4j.

Yes, exactly, we would need to somehow store it for every logger we create. In your PoC I see dynamic logging level change for all loggers. That's ok, but more important part of this issue is level for specific loggers. I consider configuring it via HTTP API rather optional. More important is to configure this via cli, because it can survive restart.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 5, 2023
@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Oct 9, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 9, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Apr 10, 2024
@lahabana
Copy link
Contributor

Duplicate of: #10230

@lahabana lahabana closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
@lahabana lahabana added triage/duplicated already exists and removed triage/accepted The issue was reviewed and is complete enough to start working on it labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/duplicated already exists
Projects
None yet
Development

No branches or pull requests

4 participants