Skip to content

Commit

Permalink
feat(kuma-dp): disable application probe proxy by default on Universal (
Browse files Browse the repository at this point in the history
#12002)

## Motivation

fixes #11854

## Implementation information

`kuma-dp` decides whether to start the application probe proxy according
to port settings on `applicationProbeProxyServer.port`, when it's
configured to `0`, the server won't start.

It was set to `9001` by default. So now change this default value to
"not set", which will be actually `0`.
On Kubernetes, we have another injector configuration item which still
defaults to `9901`, it will eventually be applied to the `kuma-dp`
process in the pod. Users can use environment variable and data plane
pod annotation to configure this port. So the functionality of the
feature is not impacted at all.

## Supporting documentation


https://kuma.io/docs/2.9.x/policies/service-health-probes/#application-probe-proxy

<!--
> Changelog: skip
-->
<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

Signed-off-by: Jay Chen <[email protected]>
  • Loading branch information
jijiechen authored Nov 12, 2024
1 parent 4027d90 commit eae59d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/config/app/kuma-dp/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ var DefaultConfig = func() Config {
CoreDNSLogging: false,
},
ApplicationProbeProxyServer: ApplicationProbeProxyServer{
Port: 9001,
Port: 0,
},
}
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/config/app/kuma-dp/testdata/default-config.golden.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
applicationProbeProxyServer:
port: 9001
applicationProbeProxyServer: {}
controlPlane:
caCert: ""
caCertFile: ""
Expand Down

0 comments on commit eae59d5

Please sign in to comment.