Fix rcps test and mamba imports#65
Open
eric-czech wants to merge 1 commit intokuleshov-group:mainfrom
Open
Conversation
Contributor
|
This is really clean and nice, thanks! Did you test that the change is non-breaking for running pre-training, e.g.? If so, happy to merge this in. |
Collaborator
Author
Non-breaking in what sense? I'd argue that the bar for testing should be what's in the unit tests or CI workflows (or some other repeatable process for everyone), so here are some options that come to mind:
My suggestion would be to make a best-effort to carry support for Mamba 1.x without any real guarantees (for a time), and test Mamba 2.x+ well. Would you agree, or is there a good argument for not building on Mamba 2 instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test_rcps.py#test_rcps_add_norm_wrapper test was failing for me for two reasons:
mamba_ssm.ops.triton.layernormrather than also checkingmamba_ssm.ops.triton.layer_norm(like modeling_caduceus.py does).I cleaned up the way version-dependent mamba modules and classes are loaded in this PR and fixed that test.