Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require QPALM_jll 0.3 #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

require QPALM_jll 0.3 #9

wants to merge 3 commits into from

Conversation

dpo
Copy link
Contributor

@dpo dpo commented Jul 7, 2021

I updated the precompiled binaries. Let's see if tests pass on Windows now.

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #9 (5d245be) into master (42c0388) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   78.67%   78.83%   +0.15%     
==========================================
  Files           2        3       +1     
  Lines         136      137       +1     
==========================================
+ Hits          107      108       +1     
  Misses         29       29              
Impacted Files Coverage Δ
src/QPALM.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c0388...5d245be. Read the comment docs.

@dpo
Copy link
Contributor Author

dpo commented Jul 7, 2021

@dpo
Copy link
Contributor Author

dpo commented Jul 8, 2021

Works with julia 1.3 now. There’s an issue on Ubuntu with the latest stable version of julia: https://github.com/kul-optec/QPALM.jl/pull/9/checks?check_run_id=3019436455#step:6:620

And Windows’s still not working.

@dpo dpo changed the title require QPALM_jll 0.2 require QPALM_jll 0.3 Jul 8, 2021
@Benny44
Copy link
Collaborator

Benny44 commented Jul 8, 2021

Strange, all the tests in C (and the demos through Matlab) were working (both on my local Ubuntu and Windows), so there might be some Julia(interface) related bug. In any case, I have no time at the moment but will try to fix it asap, hopefully before the end of this month.

@dpo
Copy link
Contributor Author

dpo commented Jul 8, 2021

Those tests were passing earlier with the version of the binaries built for Julia 1.6. This could either be a bug in the Julia interface that went unnoticed before, or something that was fixed between Julia 1.3 and Julia 1.6.

Perhaps you could double check with Julia 1.3 and your own binaries on Ubuntu.

@Benny44
Copy link
Collaborator

Benny44 commented Jul 19, 2021

I am now getting ERROR: LoadError: ArgumentError: Package QPALM does not have QPALM_jll in its dependencies: (with some stacktrace). Any ideas? In the Project.toml file QPALM_jll is listed though.

Maybe we can continue this on a chatting platform, f.e. Skype?

@dpo
Copy link
Contributor Author

dpo commented Jul 19, 2021

Do you have a Slack channel?

@Benny44
Copy link
Collaborator

Benny44 commented Jul 19, 2021

Nope, but I just made one. Can you try this?
https://join.slack.com/t/kuleuven-o7r6158/shared_invite/zt-t168nibr-OMXLLjxrAFDaArpxNUNQug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants