-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require QPALM_jll 0.3 #9
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 78.67% 78.83% +0.15%
==========================================
Files 2 3 +1
Lines 136 137 +1
==========================================
+ Hits 107 108 +1
Misses 29 29
Continue to review full report at Codecov.
|
Still some issues on Windows:
I’m investigating the version problem with Julia 1.3. |
Works with julia 1.3 now. There’s an issue on Ubuntu with the latest stable version of julia: https://github.com/kul-optec/QPALM.jl/pull/9/checks?check_run_id=3019436455#step:6:620 And Windows’s still not working. |
Strange, all the tests in C (and the demos through Matlab) were working (both on my local Ubuntu and Windows), so there might be some Julia(interface) related bug. In any case, I have no time at the moment but will try to fix it asap, hopefully before the end of this month. |
Those tests were passing earlier with the version of the binaries built for Julia 1.6. This could either be a bug in the Julia interface that went unnoticed before, or something that was fixed between Julia 1.3 and Julia 1.6. Perhaps you could double check with Julia 1.3 and your own binaries on Ubuntu. |
I am now getting ERROR: LoadError: ArgumentError: Package QPALM does not have QPALM_jll in its dependencies: (with some stacktrace). Any ideas? In the Project.toml file QPALM_jll is listed though. Maybe we can continue this on a chatting platform, f.e. Skype? |
Do you have a Slack channel? |
Nope, but I just made one. Can you try this? |
I updated the precompiled binaries. Let's see if tests pass on Windows now.