history command: first draft#7
Merged
Merged
Conversation
Closed
Owner
|
Don't see the tests |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a first draft of a history command that displays copy history using the EventEmitter, Singleton, and Command patterns.
- Added a new HistoryCommand integrated with Commander.
- Implemented a SQLite-backed HistoryRepository to store and retrieve history records.
- Registered the history command in the CLI.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/events.ts | Adds a shared EventEmitter instance |
| src/modules/commands/HistoryCommand/index.ts | Implements HistoryCommand using Commander |
| src/modules/commands/HistoryCommand/historyRepository.ts | Introduces SQLite-backed persistent storage for records |
| src/modules/commands/HistoryCommand/history.ts | Implements command logic including navigation handling |
| src/cli.ts | Registers the HistoryCommand in the CLI |
| package.json | Adds new sqlite3 dependency |
kujo205
requested changes
Jun 2, 2025
Owner
kujo205
left a comment
There was a problem hiding this comment.
Need to implement the command and add tests
8569c3f to
0e0d476
Compare
0e0d476 to
9dee154
Compare
Collaborator
Author
|
@kujo205 review the code pls |
kujo205
requested changes
Jun 3, 2025
6fd6598 to
509ef93
Compare
Owner
|
No test but who cares lets merge |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very first draft of a history command
(hopefully will be improved later and properly tested)
EventEmitter, Singleton and Command patterns are used.
mainbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000Fixes #4