-
Notifications
You must be signed in to change notification settings - Fork 265
docs/compute/virtual_hardware.md: add VideoConfig feature gate and video type override support #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4a443b8
to
f303ff7
Compare
f303ff7
to
a51c90d
Compare
docs/compute/virtual_hardware.md
Outdated
To enable custom video device configuration, the `VideoConfig` feature | ||
gate must be activated in the KubeVirt CR. | ||
|
||
**For CNV 4.21+**: You can enable the feature gate through the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is upstream documentation, can you please refer to the corresponding HCO version instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's currently in main.. no actual release in upstream.
i think we can drop this part, and update the docs once we have formal release for that
what do you think?
I can add a TODO for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
- Document VideoConfig feature gate configuration - Add architecture-specific video type support table - Update examples with correct video.type syntax - Update default video memory overhead from 16MB to 32MB Signed-off-by: Daniel Sionov <[email protected]>
a51c90d
to
0c74c87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
This PR enhances the documentation around the VideoConfig feature by adding clear guidance and updates. It documents how to configure the VideoConfig feature gate, introduces an architecture-specific support table for video types, updates examples to use the correct video.type syntax, and adjusts the default video memory overhead from 16 MB to 32 MB for improved accuracy.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to kubevirt/enhancements#87
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: