Skip to content

Conversation

dasionov
Copy link
Contributor

@dasionov dasionov commented Sep 18, 2025

What this PR does / why we need it:

This PR enhances the documentation around the VideoConfig feature by adding clear guidance and updates. It documents how to configure the VideoConfig feature gate, introduces an architecture-specific support table for video types, updates examples to use the correct video.type syntax, and adjusts the default video memory overhead from 16 MB to 32 MB for improved accuracy.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to kubevirt/enhancements#87

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

Add VideoConfig feature gate support to docs

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 18, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jean-edouard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dasionov dasionov force-pushed the add-docs-for-video-config branch from 4a443b8 to f303ff7 Compare October 2, 2025 21:45
@dasionov dasionov force-pushed the add-docs-for-video-config branch from f303ff7 to a51c90d Compare October 12, 2025 10:36
To enable custom video device configuration, the `VideoConfig` feature
gate must be activated in the KubeVirt CR.

**For CNV 4.21+**: You can enable the feature gate through the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is upstream documentation, can you please refer to the corresponding HCO version instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's currently in main.. no actual release in upstream.

i think we can drop this part, and update the docs once we have formal release for that

what do you think?

I can add a TODO for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

- Document VideoConfig feature gate configuration
- Add architecture-specific video type support table
- Update examples with correct video.type syntax
- Update default video memory overhead from 16MB to 32MB

Signed-off-by: Daniel Sionov <[email protected]>
@dasionov dasionov force-pushed the add-docs-for-video-config branch from a51c90d to 0c74c87 Compare October 14, 2025 22:38
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants