-
Notifications
You must be signed in to change notification settings - Fork 266
Update network binding plugins documentation to reflect GA status #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update network binding plugins documentation to reflect GA status #926
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5237333 to
4da45da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Human reviewed. Many changes to make.
| @@ -1,5 +1,5 @@ | |||
| # Network Binding Plugins | |||
| [v1.4.0, Beta feature] | |||
| [v1.5.0, GA feature] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could just remove this altogether.
| > **Note**: The network binding plugin infrastructure is GA as of v1.5.0. | ||
| > The SLIRP plugin is stable for production use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant; covered below under feature gates.
| > **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default. | ||
| > No feature gate activation is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default. | |
| > No feature gate activation is required. | |
| As of v1.5.0, the Network Binding Plugin feature enabled by default and has no feature gate. | |
| The slirp plugin similarly has no feature gate of its own, but the plugin needs to be made available in the cluster by [registering it](./#slirp-registration). |
| > **Note**: The specific slirp plugin has no feature gate of its own. It is up to the cluster | ||
| > admin to decide if the plugin is to be available in the cluster by registering it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the previous suggestion looks good, remove this.
| > **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default. | ||
| > No feature gate activation is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default. | |
| > No feature gate activation is required. | |
| As of v1.5.0, the Network Binding Plugin feature enabled by default and has no feature gate. | |
| The passt plugin similarly has no feature gate of its own, but the plugin needs to be made available in the cluster by [registering it](./#passt-registration). |
| > **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default. | ||
| > No feature gate activation is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of v1.5.0, the Network Binding Plugin feature enabled by default and has no feature gate.
The macvtap plugin similarly has no feature gate of its own, but the plugin needs to be made available in the cluster by registering it.
| > **Note**: The specific macvtap plugin has no feature gate of its own. It is up to the cluster | ||
| > admin to decide if the plugin is to be available in the cluster by registering it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the above suggestion looks good, remove this note.
|
|
||
| > **Important**: The core macvtap binding was discontinued and removed in v1.3.0 (deprecated in v1.2.0). | ||
| > This documentation covers the **network binding plugin** implementation of macvtap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > **Important**: The core macvtap binding was discontinued and removed in v1.3.0 (deprecated in v1.2.0). | |
| > This documentation covers the **network binding plugin** implementation of macvtap. | |
| The experimental core macvtap binding was discontinued and removed in v1.3.0 (deprecated in v1.2.0). | |
| This documentation covers the **network binding plugin** implementation of macvtap. |
| The binding plugin replaces the experimental core macvtap binding implementation | ||
| (including its API). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can now remove this as it's covered in more specific detail in the previous line
| > **Note**: The network binding plugin infrastructure is GA as of v1.5.0. | ||
| > The macvtap plugin is stable for production use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
- Update network binding plugins feature status from Beta to GA (v1.5.0) - Remove version-specific tags from plugin listings and main page - Update passt, slirp, and macvtap plugin documentation: - Remove Alpha/Beta status warnings and redundant production notes - Update feature gate requirements (now GA by default) - Clarify core binding vs plugin distinctions for slirp and macvtap - Add important notes about removed core bindings - Standardize messaging and improve text consistency across all files - Remove redundant phrasing and unnecessary sections Fixes: kubevirt#918 Co-Authored-By: Claude <[email protected]> Signed-off-by: Andrew Burden <[email protected]>
4da45da to
1dde4f5
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes: #918
Additional context:
Release note: