Skip to content

Conversation

@aburdenthehand
Copy link
Member

@aburdenthehand aburdenthehand commented Sep 16, 2025

  • Update network binding plugins feature status from Beta to GA (v1.5.0)
  • Remove version-specific tags from plugin listings
  • Update passt, slirp, and macvtap plugin documentation:
    • Remove Alpha/Beta status warnings
    • Update feature gate requirements (now GA by default)
    • Clarify core binding vs plugin distinctions for slirp and macvtap
    • Add important notes about removed core bindings

Fixes: #918

Additional context:

  • Robot 1 (NotebookLM) identified a list of 20+ inconsistencies between our release notes and our docs.
  • Robot 2 (Claude) reviewed this list and compiled them into 8 issues. It then created this PR to resolve the first one.
  • Robot 3 (different Claude) reviewed the PR and picked up some nitpicks, some of which belonged to lines that no longer make sense within the GA context.
  • Human author then reviewed all the changes in context (netlify build) and saw that a lot of these changes could be condensed, or were updates to things that could otherwise just be removed.

Release note:

NONE

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 16, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eddev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aburdenthehand aburdenthehand changed the title WIP Update network binding plugins documentation to reflect GA status Update network binding plugins documentation to reflect GA status Sep 16, 2025
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
@aburdenthehand aburdenthehand added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
@aburdenthehand aburdenthehand force-pushed the feature-lifecycle-updates-network branch from 5237333 to 4da45da Compare September 16, 2025 12:33
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
Copy link
Member Author

@aburdenthehand aburdenthehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Human reviewed. Many changes to make.

@@ -1,5 +1,5 @@
# Network Binding Plugins
[v1.4.0, Beta feature]
[v1.5.0, GA feature]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could just remove this altogether.

Comment on lines 19 to 20
> **Note**: The network binding plugin infrastructure is GA as of v1.5.0.
> The SLIRP plugin is stable for production use.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant; covered below under feature gates.

Comment on lines 37 to 38
> **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default.
> No feature gate activation is required.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default.
> No feature gate activation is required.
As of v1.5.0, the Network Binding Plugin feature enabled by default and has no feature gate.
The slirp plugin similarly has no feature gate of its own, but the plugin needs to be made available in the cluster by [registering it](./#slirp-registration).

Comment on lines 40 to 41
> **Note**: The specific slirp plugin has no feature gate of its own. It is up to the cluster
> admin to decide if the plugin is to be available in the cluster by registering it.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the previous suggestion looks good, remove this.

Comment on lines 124 to 125
> **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default.
> No feature gate activation is required.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default.
> No feature gate activation is required.
As of v1.5.0, the Network Binding Plugin feature enabled by default and has no feature gate.
The passt plugin similarly has no feature gate of its own, but the plugin needs to be made available in the cluster by [registering it](./#passt-registration).

Comment on lines 146 to 147
> **Note**: As of v1.5.0, the Network Binding Plugin feature is GA and enabled by default.
> No feature gate activation is required.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of v1.5.0, the Network Binding Plugin feature enabled by default and has no feature gate.
The macvtap plugin similarly has no feature gate of its own, but the plugin needs to be made available in the cluster by registering it.

Comment on lines 149 to 150
> **Note**: The specific macvtap plugin has no feature gate of its own. It is up to the cluster
> admin to decide if the plugin is to be available in the cluster by registering it.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the above suggestion looks good, remove this note.

Comment on lines +124 to +126

> **Important**: The core macvtap binding was discontinued and removed in v1.3.0 (deprecated in v1.2.0).
> This documentation covers the **network binding plugin** implementation of macvtap.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Important**: The core macvtap binding was discontinued and removed in v1.3.0 (deprecated in v1.2.0).
> This documentation covers the **network binding plugin** implementation of macvtap.
The experimental core macvtap binding was discontinued and removed in v1.3.0 (deprecated in v1.2.0).
This documentation covers the **network binding plugin** implementation of macvtap.

Comment on lines 128 to 129
The binding plugin replaces the experimental core macvtap binding implementation
(including its API).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now remove this as it's covered in more specific detail in the previous line

Comment on lines 131 to 132
> **Note**: The network binding plugin infrastructure is GA as of v1.5.0.
> The macvtap plugin is stable for production use.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

- Update network binding plugins feature status from Beta to GA (v1.5.0)
- Remove version-specific tags from plugin listings and main page
- Update passt, slirp, and macvtap plugin documentation:
  - Remove Alpha/Beta status warnings and redundant production notes
  - Update feature gate requirements (now GA by default)
  - Clarify core binding vs plugin distinctions for slirp and macvtap
  - Add important notes about removed core bindings
- Standardize messaging and improve text consistency across all files
- Remove redundant phrasing and unnecessary sections

Fixes: kubevirt#918

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Andrew Burden <[email protected]>
@aburdenthehand aburdenthehand force-pushed the feature-lifecycle-updates-network branch from 4da45da to 1dde4f5 Compare September 17, 2025 09:50
@aburdenthehand aburdenthehand mentioned this pull request Sep 17, 2025
8 tasks
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Network Binding Plugins Documentation to Reflect Feature Lifecycle Changes

2 participants