fix: make NodeUnpublishVolume idempotent

[jaskiratsingh98]

Make NodeUnpublishVolume idempotent by only removing the mount if one exists.

What this PR does / why we need it:
The goal is to make NodeUnpublishVolume idempotent as required by the CSI spec. Previously, if a mount was already removed, this call would fail and would ultimately be re-queued. This would, for example, lead to pods getting stuck in a Terminating state."

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NodeUnpublishVolume is now idempotent by ensuring a mount exists before trying to unmount.

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign awels for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-bot]

Hi @jaskiratsingh98. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[akalenyu]

I was just tackling this too in #165, but apparently it is solved by using the proper mount utils library -

csi-driver/vendor/k8s.io/mount-utils/mount_linux.go

Lines 930 to 933 in 7cd7c19

	if withSafeNotMountedBehavior && strings.Contains(string(output), errNotMounted) {
	klog.V(4).Infof("ignoring 'not mounted' error for %s", target)
	return nil
	}

(on most distros)

In which version are you seeing this? we could still ofc do better with the cleanup API