Chore: Update the go version to 1.22

.github/workflows/e2e.yaml

@@ -15,8 +15,8 @@ on:
 
 env:
   # Common versions
-  GO_VERSION: '1.19'
-  GOLANGCI_VERSION: 'v1.49'
+  GO_VERSION: '1.22'
+  GOLANGCI_VERSION: 'v1.59'
   K3D_IMAGE_VERSION: '[\"v1.26\"]'
   K3D_IMAGE_VERSIONS: '[\"v1.26\"]'
 

.github/workflows/go.yaml

@@ -13,8 +13,8 @@ on:
 
 env:
   # Common versions
-  GO_VERSION: '1.19'
-  GOLANGCI_VERSION: 'v1.49'
+  GO_VERSION: '1.22'
+  GOLANGCI_VERSION: 'v1.59'
 
 jobs:
 
@@ -49,14 +49,14 @@ jobs:
           submodules: true
 
       - name: Cache Go Dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: .work/pkg
           key: ${{ runner.os }}-pkg-${{ hashFiles('**/go.sum') }}
           restore-keys: ${{ runner.os }}-pkg-
 
       - name: Install StaticCheck
-        run: go install honnef.co/go/tools/cmd/staticcheck@2022.1
+        run: go install honnef.co/go/tools/cmd/staticcheck@2023.1.7
 
       - name: Static Check
         run: staticcheck ./...
@@ -78,7 +78,7 @@ jobs:
           submodules: true
 
       - name: Cache Go Dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: .work/pkg
           key: ${{ runner.os }}-pkg-${{ hashFiles('**/go.sum') }}

.github/workflows/post-submit.yaml

@@ -7,7 +7,7 @@ on:
   workflow_dispatch: {}
 
 env:
-  GO_VERSION: '1.19'
+  GO_VERSION: '1.22'
 
 jobs:
 

.github/workflows/unit-test.yaml

@@ -13,8 +13,8 @@ on:
 
 env:
   # Common versions
-  GO_VERSION: '1.19'
-  GOLANGCI_VERSION: 'v1.49'
+  GO_VERSION: '1.22'
+  GOLANGCI_VERSION: 'v1.59'
   KIND_VERSION: 'v0.7.0'
 
 jobs:

Dockerfile

@@ -1,6 +1,6 @@
 ARG BASE_IMAGE
 # Build the manager binary
-FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.19-alpine as builder
+FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.22-alpine as builder
 ARG GOPROXY
 ENV GOPROXY=${GOPROXY:-https://goproxy.cn}
 WORKDIR /workspace

Dockerfile.e2e

@@ -1,6 +1,6 @@
 ARG BASE_IMAGE
 # Build the manager binary
-FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.19-alpine as builder
+FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.22-alpine as builder
 ARG GOPROXY
 ENV GOPROXY=${GOPROXY:-https://goproxy.cn}
 WORKDIR /workspace

cmd/main.go

@@ -341,7 +341,7 @@ func waitWebhookSecretVolume(certDir string, timeout, interval time.Duration) er
 					return false
 				}
 				// check if secret files are empty
-				err = filepath.Walk(certDir, func(path string, info os.FileInfo, err error) error {
+				err = filepath.Walk(certDir, func(path string, info os.FileInfo, err error) error { //nolint:revive,unused
 					// even Cert dir is created, cert files are still empty for a while
 					if info.Size() == 0 {
 						return errors.New("secret is not ready")

controllers/backup_controller.go

@@ -172,14 +172,14 @@ func (r *BackupReconciler) SetupWithManager(mgr ctrl.Manager) error {
 			// filter the changes in workflow status
 			// let workflow handle its reconcile
 			UpdateFunc: func(e ctrlEvent.UpdateEvent) bool {
-				new := e.ObjectNew.DeepCopyObject().(*v1alpha1.WorkflowRun)
-				old := e.ObjectOld.DeepCopyObject().(*v1alpha1.WorkflowRun)
+				newObj := e.ObjectNew.DeepCopyObject().(*v1alpha1.WorkflowRun)
+				oldObj := e.ObjectOld.DeepCopyObject().(*v1alpha1.WorkflowRun)
 				// if the workflow is not finished, skip the reconcile
-				if !new.Status.Finished {
+				if !newObj.Status.Finished {
 					return false
 				}
 
-				return !reflect.DeepEqual(old, new)
+				return !reflect.DeepEqual(oldObj, newObj)
 			},
 			CreateFunc: func(e ctrlEvent.CreateEvent) bool {
 				run := e.Object.DeepCopyObject().(*v1alpha1.WorkflowRun)

controllers/workflowrun_controller.go

@@ -216,37 +216,37 @@ func (r *WorkflowRunReconciler) SetupWithManager(mgr ctrl.Manager) error {
 			// filter the changes in workflow status
 			// let workflow handle its reconcile
 			UpdateFunc: func(e ctrlEvent.UpdateEvent) bool {
-				new, isNewWR := e.ObjectNew.DeepCopyObject().(*v1alpha1.WorkflowRun)
-				old, isOldWR := e.ObjectOld.DeepCopyObject().(*v1alpha1.WorkflowRun)
+				newObj, isNewWR := e.ObjectNew.DeepCopyObject().(*v1alpha1.WorkflowRun)
+				oldObj, isOldWR := e.ObjectOld.DeepCopyObject().(*v1alpha1.WorkflowRun)
 
 				// if the object is a event listener, reconcile the controller
 				if !isNewWR || !isOldWR {
 					return true
 				}
 
 				// if the workflow is finished, skip the reconcile
-				if new.Status.Finished {
+				if newObj.Status.Finished {
 					return false
 				}
 
 				// filter managedFields changes
-				old.ManagedFields = nil
-				new.ManagedFields = nil
+				oldObj.ManagedFields = nil
+				newObj.ManagedFields = nil
 
 				// filter resourceVersion changes
-				old.ResourceVersion = new.ResourceVersion
+				oldObj.ResourceVersion = newObj.ResourceVersion
 
 				// if the generation is changed, return true to let the controller handle it
-				if old.Generation != new.Generation {
+				if oldObj.Generation != newObj.Generation {
 					return true
 				}
 
 				// ignore the changes in step status
-				old.Status.Steps = new.Status.Steps
+				oldObj.Status.Steps = newObj.Status.Steps
 
-				return !reflect.DeepEqual(old, new)
+				return !reflect.DeepEqual(oldObj, newObj)
 			},
-			CreateFunc: func(e ctrlEvent.CreateEvent) bool {
+			CreateFunc: func(e ctrlEvent.CreateEvent) bool { //nolint:revive,unused
 				return true
 			},
 		}).

go.mod

@@ -1,6 +1,6 @@
 module github.com/kubevela/workflow
 
-go 1.19
+go 1.22
 
 require (
 	cuelang.org/go v0.5.0