Feat: add default suspend message (#141)

Signed-off-by: FogDong <[email protected]>
kubevela · Feb 27, 2023 · 8eae143 · 8eae143
1 parent 6da55e8
commit 8eae143
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/providers/workspace/workspace.go b/pkg/providers/workspace/workspace.go
@@ -130,6 +130,9 @@ func (h *provider) Suspend(ctx monitorContext.Context, wfCtx wfContext.Context,
 	var msg string
 	if v != nil {
 		msg, _ = v.GetString("message")
+		if msg == "" {
+			msg = fmt.Sprintf("Suspended by field %s", v.FieldName())
+		}
 	}
 	if timestamp != "" {
 		t, err := time.Parse(time.RFC3339, timestamp)

diff --git a/pkg/providers/workspace/workspace_test.go b/pkg/providers/workspace/workspace_test.go
@@ -156,13 +156,12 @@ func TestProvider_Suspend(t *testing.T) {
 	act := &mockAction{}
 	v, err := value.NewValue(`
 duration: "1s"
-message: "hello suspend"
 `, nil, "")
 	r.NoError(err)
 	err = p.Suspend(nil, wfCtx, v, act)
 	r.NoError(err)
 	r.Equal(act.suspend, true)
-	r.Equal(act.msg, "hello suspend")
+	r.Equal(act.msg, "Suspended by field ")
 	// test second time to check if the suspend is resumed in 1s
 	err = p.Suspend(nil, wfCtx, v, act)
 	r.NoError(err)