Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign KubeCon links on the main page #49167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shurup
Copy link
Member

@shurup shurup commented Dec 19, 2024

Description

I'm suggesting this redesign of the "Attend KubeCon…" block on the main page (see After):

image

In my understanding, it's needed since we have five KubeCons now, and adding more huge buttons (as we did before — see Before) won't really work anymore.

While working on this design improvement, I've also noticed a long-standing HTML bug since we had such entities for the KubeCon links for many years: <a href="..." button id="desktopKCButton">. They are not valid for two reasons: a) the <a> tag does not have the button attribute, and b) we can't use the same id for numerous HTML objects on the same page. Thus, I removed the button attribute and converted desktopKCButton from id to class.

Obviously, I've also synced the actual KubeCon events (links & dates) with the upcoming 2025 events.

I've checked how the suggested changes are rendered in two browsers (Firefox and Chrome in Linux). However, more testing, as well as general feedback, will be very much appreciated.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot requested review from sftim and tengqm December 19, 2024 11:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b9f2a8a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/676405b13c7f210008bb3803
😎 Deploy Preview https://deploy-preview-49167--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NameNoQuality
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented Dec 27, 2024

I think we could use a more comprehensive redesign of our landing page.

This is progress. However, we shouldn't merge this as-is @shurup. Please look at the localized versions of this page; you'll see that the proposed change will break rendering for some (eg Korean).
Can we find a way to make an incremental change that leaves localizations' landing pages looking OK until they have caught up?

@shurup
Copy link
Member Author

shurup commented Dec 27, 2024

Good catch, thank you! I will find a way to keep the "backward compatibility."

P.S. Regarding a more general redesign of this page, I was actually thinking of suggesting some new options to replace that old video (behind the KubeCon links) as my next step...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants