Redesign KubeCon links on the main page #49167
Open
+17
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm suggesting this redesign of the "Attend KubeCon…" block on the main page (see After):
In my understanding, it's needed since we have five KubeCons now, and adding more huge buttons (as we did before — see Before) won't really work anymore.
While working on this design improvement, I've also noticed a long-standing HTML bug since we had such entities for the KubeCon links for many years:
<a href="..." button id="desktopKCButton">
. They are not valid for two reasons: a) the<a>
tag does not have thebutton
attribute, and b) we can't use the sameid
for numerous HTML objects on the same page. Thus, I removed thebutton
attribute and converteddesktopKCButton
fromid
toclass
.Obviously, I've also synced the actual KubeCon events (links & dates) with the upcoming 2025 events.
I've checked how the suggested changes are rendered in two browsers (Firefox and Chrome in Linux). However, more testing, as well as general feedback, will be very much appreciated.