fix: search bar should be removed in page find results and should be present in the sidebar

Author: SayakMukhopadhyay

assets/js/custom-search.js

@@ -22,7 +22,7 @@ window.renderGoogleSearchResults = () => {
 window.renderPageFindSearchResults = () => {
   let urlParams = new URLSearchParams(window.location.search);
   let searchTerm = urlParams.get("q") || "";
-  let sidebarSearch = document.querySelector('.td-sidebar__search');
+  let sidebarSearch = document.querySelector('#search-results-search');
   if (sidebarSearch) {
     sidebarSearch.remove();
   }

layouts/_default/search.html

@@ -3,8 +3,14 @@
 Revisit this if / when either of https://github.com/google/docsy/issues/2194 and https://github.com/google/docsy/pull/1512 are closed
 */}}
 {{ define "main" }}
-<!--From shortcodes/site-searchbar.html which is used in the home page-->
-<div class="col-sm-6 col-md-6 col-lg-6 mx-auto py-3">
+
+{{/*
+Do not use the `search-results-search` id elsewhere as it is used
+delete this element for pagefind/China users
+*/}}
+
+{{/* From shortcodes/site-searchbar.html which is used in the home page */}}
+<div id="search-results-search" class="col-sm-6 col-md-6 col-lg-6 mx-auto py-3">
   {{partial "search-input" .}}
 </div>
 <section class="row td-search-result">