Skip to content

Commit 0f84821

Browse files
fix: first line comments need to be in the {{/* */}} block, see gohugoio/hugo#7243
Apply suggestions from code review Co-authored-by: Tim Bannister <[email protected]> fix: apply review suggestions
1 parent d247255 commit 0f84821

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

layouts/_default/search.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
<!--
1+
{{/*
22
Copied from Docsy with the addition of the search-input and the customSearch block.
3-
Revisit this once https://github.com/google/docsy/issues/2194 and https://github.com/google/docsy/pull/1512 are closed
4-
-->
3+
Revisit this if / when either of https://github.com/google/docsy/issues/2194 and https://github.com/google/docsy/pull/1512 are closed
4+
*/}}
55
{{ define "main" }}
66
<!--From shortcodes/site-searchbar.html which is used in the home page-->
77
<div class="col-sm-6 col-md-6 col-lg-6 mx-auto py-3">

layouts/partials/scripts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
{{ $jsSearch := resources.Get "js/search.js" | resources.ExecuteAsTemplate "js/search.js" .Site.Home }}
3434
{{ if .Site.Params.offlineSearch }}
3535
{{ $jsSearch = resources.Get "js/offline-search.js" }}
36-
<!-- Revisit this once https://github.com/google/docsy/issues/2194 and https://github.com/google/docsy/pull/1512 are closed -->
36+
{{/* Revisit this if / when either of https://github.com/google/docsy/issues/2194 and https://github.com/google/docsy/pull/1512 are closed */}}
3737
{{ else if .Site.Params.customSearch }}
3838
{{ $jsSearch = resources.Get "js/custom-search.js" }}
3939
{{ end }}

layouts/partials/search-input-custom.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!-- Revisit this once https://github.com/google/docsy/issues/2194 and https://github.com/google/docsy/pull/1512 are closed -->
1+
{{/* Revisit this if / when either of https://github.com/google/docsy/issues/2194 and https://github.com/google/docsy/pull/1512 are closed */}}
22
{{ $lang := .Site.Language.Lang }}
33
{{ $searchFile := printf "content/%s/search.md" $lang }}
44

layouts/partials/search-input.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
<!--
1+
{{/*
22
Copied from Docsy with the addition of the customSearch block.
33
This can be deleted once https://github.com/google/docsy/issues/2194 and https://github.com/google/docsy/pull/1512 are closed
4-
-->
4+
and the site has been updated to incorporate the upstream change.
5+
*/}}
56
{{ if .Site.Params.gcs_engine_id -}}
67
<div class="td-search">
78
<div class="td-search__icon"></div>

0 commit comments

Comments
 (0)