Skip to content

fix non-constant format string errors #35806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix non-constant format string errors #35806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gcsweb/cmd/gcsweb/gcsweb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ func TestGetParent(t *testing.T) {
t.Run(tc.id, func(t *testing.T) {
actual := getParent(tc.path)
if !reflect.DeepEqual(tc.expected, actual) {
t.Fatalf(cmp.Diff(tc.expected, actual))
t.Fatal(cmp.Diff(tc.expected, actual))
}
})
}
Expand Down
8 changes: 4 additions & 4 deletions kubetest/aksengine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,16 +1189,16 @@ func (c *aksEngineDeployer) DumpClusterLogs(localPath, gcsPath string) error {
return nil
}

var errors []string
var errs []string
if err := logDumper(); err != nil {
errors = append(errors, err.Error())
errs = append(errs, err.Error())
}
if err := logDumperWindows(); err != nil {
// don't log error since logDumperWindows failed is expected on non-Windows cluster
_ = err
}
if len(errors) != 0 {
return fmt.Errorf(strings.Join(errors, "\n"))
if len(errs) != 0 {
return errors.New(strings.Join(errs, "\n"))
}
return nil
}
Expand Down