Skip to content

SIG testing: use only label filter for alpha/beta jobs #35575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+12 −0
Closed

SIG testing: use only label filter for alpha/beta jobs #35575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,10 @@ presubmits:
value: '{"AllBeta":true}'
- name: RUNTIME_CONFIG
value: '{"api/beta":"true", "api/ga":"true"}'
- name: SKIP
value: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

This does not actually work 😠

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/134250/pull-kubernetes-e2e-kind-alpha-beta-enabled/1971169750193016832 used it and still got '--ginkgo.skip=[Serial]' added.

Whatever does that is missing a "variable already set" check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC it's the script in kind, but we also have the overly complex ginkgo-e2e.sh in k/k, I still want to do kubernetes/kubernetes#131058 but we had more pending discussion it seemed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

I followed up on this in:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/close

Replaced by #35594.

- name: FOCUS
value: ""
- name: LABEL_FILTER
value: "Feature: isSubsetOf OffByDefault && !Alpha && !Deprecated && !Slow && !Disruptive && !Flaky"
- name: PARALLEL
Expand Down Expand Up @@ -346,6 +350,10 @@ presubmits:
value: '{"AllAlpha":true,"AllBeta":true,"EventedPLEG":false}'
- name: RUNTIME_CONFIG
value: '{"api/all":"true"}'
- name: SKIP
value: ""
- name: FOCUS
value: ""
- name: LABEL_FILTER
value: "Feature: isSubsetOf OffByDefault && !Deprecated && !Slow && !Disruptive && !Flaky"
- name: PARALLEL
Expand Down Expand Up @@ -392,6 +400,10 @@ presubmits:
value: '{"AllAlpha":true,"AllBeta":true,"EventedPLEG":false}'
- name: RUNTIME_CONFIG
value: '{"api/all":"true"}'
- name: SKIP
value: ""
- name: FOCUS
value: ""
- name: LABEL_FILTER
value: "Feature: isSubsetOf OffByDefault && !Deprecated && !Slow && !Disruptive && !Flaky"
- name: PARALLEL
Expand Down