-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Always set AllBeta with AllAlpha for alpha CI jobs #35546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It turned out to be used in more places than I expected /lgtm holding for others to chime in and have more eyes in case some jobs break with the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
My own removal PR is a subset of this one here. It got stuck on a discussion on other next steps. Let's merge this one here, then I'll update mine to do those next steps.
Ah, sorry, I missed that you'd already started on this. Thanks. |
ec27fea
to
a6db0f5
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, BenTheElder, pohly, SergeyKanzhelev, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tallclair: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes/kubernetes#133697 adds the concept of feature-gate dependencies, and forbids enabling features with disabled dependencies. This means that if an Alpha feature depends on an off-by-default Beta, then enabling
AllAlpha
features on their own will fail. See summary of discussion here: kubernetes/kubernetes#133697 (comment)To avoid breaking our alpha CI jobs, anywhere that
AllAlpha
is enabled, we should also enableAllBeta
. In the case ofci-kubernetes-e2e-kind-alpha-features
the job was removed because there is already a similar job that enables AllAlpha and AllBeta./cc @BenTheElder @pohly @aojea @liggitt