Skip to content

Conversation

tallclair
Copy link
Member

kubernetes/kubernetes#133697 adds the concept of feature-gate dependencies, and forbids enabling features with disabled dependencies. This means that if an Alpha feature depends on an off-by-default Beta, then enabling AllAlpha features on their own will fail. See summary of discussion here: kubernetes/kubernetes#133697 (comment)

To avoid breaking our alpha CI jobs, anywhere that AllAlpha is enabled, we should also enable AllBeta. In the case of ci-kubernetes-e2e-kind-alpha-features the job was removed because there is already a similar job that enables AllAlpha and AllBeta.

/cc @BenTheElder @pohly @aojea @liggitt

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 19, 2025
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2025
@aojea
Copy link
Member

aojea commented Sep 19, 2025

It turned out to be used in more places than I expected

/lgtm
/approve

holding for others to chime in and have more eyes in case some jobs break with the change
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

My own removal PR is a subset of this one here. It got stuck on a discussion on other next steps. Let's merge this one here, then I'll update mine to do those next steps.

@github-project-automation github-project-automation bot moved this from Triage to PRs - Needs Approver in SIG Node CI/Test Board Sep 19, 2025
@tallclair
Copy link
Member Author

My own removal PR is a subset of this one here. It got stuck on a discussion on other next steps. Let's merge this one here, then I'll update mine to do those next steps.

Ah, sorry, I missed that you'd already started on this. Thanks.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 22, 2025
@BenTheElder
Copy link
Member

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder, pohly, SergeyKanzhelev, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 58ee6da into kubernetes:master Sep 23, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from PRs - Needs Approver to Done in SIG Node CI/Test Board Sep 23, 2025
@k8s-ci-robot
Copy link
Contributor

@tallclair: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-ibmcloud-ppc64le-periodics.yaml using file config/jobs/kubernetes/cloud-provider-ibmcloud/cloud-provider-ibmcloud-ppc64le-periodics.yaml
  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml
  • key kops-periodics-misc2.yaml using file config/jobs/kubernetes/kops/kops-periodics-misc2.yaml
  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key periodic-e2e.yaml using file config/jobs/kubernetes/sig-cloud-provider/periodic-e2e.yaml
  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
  • key kubernetes-kind-ci.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind-ci.yaml
  • key kubernetes-kind-presubmits.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml

In response to this:

kubernetes/kubernetes#133697 adds the concept of feature-gate dependencies, and forbids enabling features with disabled dependencies. This means that if an Alpha feature depends on an off-by-default Beta, then enabling AllAlpha features on their own will fail. See summary of discussion here: kubernetes/kubernetes#133697 (comment)

To avoid breaking our alpha CI jobs, anywhere that AllAlpha is enabled, we should also enable AllBeta. In the case of ci-kubernetes-e2e-kind-alpha-features the job was removed because there is already a similar job that enables AllAlpha and AllBeta.

/cc @BenTheElder @pohly @aojea @liggitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants