-
Notifications
You must be signed in to change notification settings - Fork 2.8k
enable multiarch support in prowjobs #35536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
-v "${REPO_ROOT:?}:${REPO_ROOT:?}" -w "${REPO_ROOT}" \ | ||
--security-opt="label=disable" \ | ||
"cytopia/yamllint:1.26@sha256:1bf8270a671a2e5f2fea8ac2e80164d627e0c5fa083759862bbde80628f942b2" \ | ||
"pipelinecomponents/yamllint:0.35.0@sha256:792a5c9f8c0f3b334996c8c5f9b58f000bd57ff8a87ba54fdd5e8d02679097f9" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this relevant to the intent of the PR ?
why the switch ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is relevant to this PR. The old image wasn't multi-arch so the lint job that I updated above would fail if it was scheduled on an arm node.
/retest |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This could actually introduce some really surprising failures, the linting jobs do actually typically lint for the host platform, and e2e runner jobs will build for the host platform assuming it is also the target platform. |
For example, when we run golangci-lint, we run it for the host architecture, it's impractical to run it for all, and that means we are going to get some different code and behavior because of code restricted by platform. Randomizing the hosts can make for difficult to debug failures, we don't surface this very well in CI, see previously with the kernel issues and the ipv6 jobs on mid-upgrade nodepool. Most of our contributors will not see what's going on there. It means the results are less comparable over time, I don't think we should do that with most of our CI. Something like, launching the cloudbuilds, sure. But basically anything that builds ... (including linting, it parses for the host platform typically) fuzzing the architecture in between runs is ... a bit chaotic. cc @kubernetes/sig-testing-leads |
It will be an opt-in feature and jobs that compile/build artefacts aren't generally not a good fit. We have many jobs that launch e2e tests on clouds and ideally, they would benefit from this change, specifically the periodic jobs that don't build kubernetes and fetch them the CI buckets. |
I introduced a new label called
preset-enable-multiarch-support: "true"
that we can set on prowjobs that will allow them to tolerate the taint set on the arm64 nodes and run on them sometimes.The intention is to attach the labels on jobs that don't care about the architecture, such as linting, verify, e2e runner jobs, etc
In the near future, the EKS cluster will also have Graviton(arm64) nodes enabled as well, so we can apply the same strategy there too.