-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip dra from serial jobs that are not dra #33996
Conversation
/assign @pohly @bart0sh @SergeyKanzhelev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a stop-gap solution this is probably what you need to do.
A better solution (as mentioned on Slack) would be to switch to --label-selector
(see #32911) because then you add an allow-list for each job once and no longer have to extend the current deny-list whenever something new comes up or (in this case) changes.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kannon92: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #33997