-
Notifications
You must be signed in to change notification settings - Fork 527
[WIP] Switch to building golang outselves #4111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
657f82f
to
88f07c1
Compare
thanks @dims i was working on that, but last week i was busy with company work. |
@cpanato definitely, wanted to pitch in .. as this came up in kubernetes-sigs/structured-merge-diff#292 (comment) again |
/test pull-release-image-go-runner |
FYI https://github.com/docker-library/golang/blob/master/Dockerfile-linux.template if we want to deal with multi-arch. |
|
i will take over not a problem, thanks Dims might have some delays as i will be traveling end of this week and will be out the entire next one, but will do my best |
88f07c1
to
6f08ab4
Compare
/test pull-release-image-go-runner |
8fa971b
to
af80483
Compare
/test pull-release-image-go-runner |
f98298d
to
b3f26af
Compare
b3f26af
to
1fab404
Compare
1fab404
to
0913ee7
Compare
see follow up with lessons learned in #4119 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?